1177927 - Simplify frame-list counting in nsPrintEngine to use GetLength()

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Daniel Holbert [:dholbert]]

While fixing bug 1177925, I noticed that nsPrintEngine walks a nsFrameList purely to count the number of frames in it.

It should simply use nsFrameList::GetLength for this.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Here's the patch.  This just replaces a loop with a call to GetLength().  (I also removed "first" from the comment, because it's not actually "first"; it's rather the last thing that we do.)

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/052df7a415f1

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/30e8c73f674e

Comment 4

[Daniel Holbert [:dholbert]]

Comment on attachment 8626797 [details] [diff] [review]
fix v1

>+  // count the total number of pages
>+  aCount = aSeqFrame->PrincipalChildList()->GetLength();

Er, PrincipalChildList() returns a nsFrameList&, so that should be .GetLength(), not ->. (I could've sworn I built this locally earlier in the week, but I guess not.)

Just pushed a followup to fix that.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/052df7a415f1
https://hg.mozilla.org/mozilla-central/rev/30e8c73f674e