Closed
Bug 1177944
Opened 10 years ago
Closed 9 years ago
Allow disabling reviewer deduction when pushing to MozReview
Categories
(MozReview Graveyard :: General, defect, P3)
MozReview Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: botond, Assigned: botond)
References
Details
Attachments
(1 file)
In the "grass is always greener on the other side" department:
We now have reviewer deduction when pushing to MozReviewer (bug 1142251), which is great!
Sometimes, though, I want to submit patches to MozReview (and publish the review request) even though they're not ready for review yet (for example, to make a patch for which a Try run hasn't finished yet available for others to use), but I still want to have the "r=reviewer" string in the commit message (so that if the patch ends up being ready for review without further changes, I don't need to change the commit message before landing).
For cases like these, it would be great to be able to disable reviewer deduction on a per-push basis with a command-line option such as:
hg push review --no-reviewer-deduction
Updated•10 years ago
|
Priority: -- → P3
Comment 2•10 years ago
|
||
We could do this by adding an option in the UI to clear reviewers. A little manual but better than a push option or prompt.
Updated•9 years ago
|
Product: Developer Services → MozReview
Assignee | ||
Comment 4•9 years ago
|
||
I'm going to give this a try, now that I'm done with bug 1231397.
Assignee: nobody → botond
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Botond Ballo [:botond] from comment #0)
> For cases like these, it would be great to be able to disable reviewer
> deduction on a per-push basis with a command-line option such as:
>
> hg push review --no-reviewer-deduction
Give that we prefer not adding top-level options to push, I'm going to try using a config option, the way we did in bug 1231973.
For example:
hg push review --config reviewboard.deduce=false
Assignee | ||
Comment 6•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/41063/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41063/
Attachment #8732272 -
Flags: review?(dminor)
Comment 7•9 years ago
|
||
Comment on attachment 8732272 [details]
MozReview Request: Bug 1177944 - Allow disabling reviewer deduction with a config option. r=glob
I've moved over to the media team, so I'm not taking new MozReview reviews. gps or glob would be good options for review.
Attachment #8732272 -
Flags: review?(dminor)
Assignee | ||
Updated•9 years ago
|
Attachment #8732272 -
Attachment description: MozReview Request: Bug 1177944 - Allow disabling reviewer deduction with a config option. r=dminor → MozReview Request: Bug 1177944 - Allow disabling reviewer deduction with a config option. r=smacleod
Attachment #8732272 -
Flags: review?(smacleod)
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8732272 [details]
MozReview Request: Bug 1177944 - Allow disabling reviewer deduction with a config option. r=glob
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41063/diff/1-2/
Assignee | ||
Comment 9•9 years ago
|
||
(In reply to Dan Minor [:dminor] from comment #7)
> I've moved over to the media team, so I'm not taking new MozReview reviews.
> gps or glob would be good options for review.
Whoops, just saw this (mcote suggested smacleod on IRC).
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8732272 [details]
MozReview Request: Bug 1177944 - Allow disabling reviewer deduction with a config option. r=glob
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41063/diff/2-3/
Attachment #8732272 -
Attachment description: MozReview Request: Bug 1177944 - Allow disabling reviewer deduction with a config option. r=smacleod → MozReview Request: Bug 1177944 - Allow disabling reviewer deduction with a config option. r=glob
Attachment #8732272 -
Flags: review?(smacleod) → review?(glob)
Assignee | ||
Comment 11•9 years ago
|
||
Apologies for the churn.
Comment 12•9 years ago
|
||
Comment on attachment 8732272 [details]
MozReview Request: Bug 1177944 - Allow disabling reviewer deduction with a config option. r=glob
https://reviewboard.mozilla.org/r/41063/#review38401
::: hgext/reviewboard/tests/test-specify-reviewers.t:596
(Diff revision 3)
> +
> + changeset: 29:ec05f2b11ce8
> + summary: Bug 2 - awesome stuff; r?remus
> + review: http://$DOCKER_HOSTNAME:$HGPORT1/r/15 (draft)
> +
> + review id: bz://2/mynick
> + review url: http://$DOCKER_HOSTNAME:$HGPORT1/r/12 (draft)
> + (review requests lack reviewers; visit review url to assign reviewers)
> +
> + publish these review requests now (Yn)? y
> + (published review request 12)
> +
this test doesn't pass for two reasons:
- the changeset hash is different (df9e974cc15e)
- trailing whitespace has been removed from the empty lines, which breaks the test diffs
Attachment #8732272 -
Flags: review?(glob)
Assignee | ||
Comment 13•9 years ago
|
||
(In reply to Byron Jones ‹:glob› from comment #12)
> this test doesn't pass for two reasons:
> - the changeset hash is different (df9e974cc15e)
> - trailing whitespace has been removed from the empty lines, which breaks
> the test diffs
Thanks for catching that! Not sure why it was passing for me when I originally tested it...
Assignee | ||
Comment 14•9 years ago
|
||
Comment on attachment 8732272 [details]
MozReview Request: Bug 1177944 - Allow disabling reviewer deduction with a config option. r=glob
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41063/diff/3-4/
Attachment #8732272 -
Flags: review?(glob)
Comment 15•9 years ago
|
||
Comment on attachment 8732272 [details]
MozReview Request: Bug 1177944 - Allow disabling reviewer deduction with a config option. r=glob
https://reviewboard.mozilla.org/r/41063/#review39415
r=glob
Attachment #8732272 -
Flags: review?(glob) → review+
Assignee | ||
Comment 16•9 years ago
|
||
Thanks for the review!
Assignee | ||
Comment 17•9 years ago
|
||
Assignee | ||
Comment 18•9 years ago
|
||
(I meant to close this when I posted the hg.m.o link.)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•