1177944 - Allow disabling reviewer deduction when pushing to MozReview

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P3)

Description

[Botond Ballo [:botond]]

In the "grass is always greener on the other side" department:

We now have reviewer deduction when pushing to MozReviewer (bug 1142251), which is great!

Sometimes, though, I want to submit patches to MozReview (and publish the review request) even though they're not ready for review yet (for example, to make a patch for which a Try run hasn't finished yet available for others to use), but I still want to have the "r=reviewer" string in the commit message (so that if the patch ends up being ready for review without further changes, I don't need to change the commit message before landing).

For cases like these, it would be great to be able to disable reviewer deduction on a per-push basis with a command-line option such as:

  hg push review --no-reviewer-deduction

Comment 2

[Mark Côté [:mcote]]

We could do this by adding an option in the UI to clear reviewers.  A little manual but better than a push option or prompt.

Comment 4

[Botond Ballo [:botond]]

I'm going to give this a try, now that I'm done with bug 1231397.

Comment 5

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #0)
> For cases like these, it would be great to be able to disable reviewer
> deduction on a per-push basis with a command-line option such as:
> 
>   hg push review --no-reviewer-deduction

Give that we prefer not adding top-level options to push, I'm going to try using a config option, the way we did in bug 1231973.

For example:

    hg push review --config reviewboard.deduce=false

Comment 6

[Botond Ballo [:botond]]

Attachment: MozReview Request: Bug 1177944 - Allow disabling reviewer deduction with a config option. r=glob

Review commit: https://reviewboard.mozilla.org/r/41063/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41063/

Comment 7

[Dan Minor [:dminor]]

Comment on attachment 8732272 [details]
MozReview Request: Bug 1177944 - Allow disabling reviewer deduction with a config option. r=glob

I've moved over to the media team, so I'm not taking new MozReview reviews. gps or glob would be good options for review.

Comment 8

[Botond Ballo [:botond]]

Comment on attachment 8732272 [details]
MozReview Request: Bug 1177944 - Allow disabling reviewer deduction with a config option. r=glob

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41063/diff/1-2/

Comment 9

[Botond Ballo [:botond]]

(In reply to Dan Minor [:dminor] from comment #7)
> I've moved over to the media team, so I'm not taking new MozReview reviews.
> gps or glob would be good options for review.

Whoops, just saw this (mcote suggested smacleod on IRC).

Comment 10

[Botond Ballo [:botond]]

Comment on attachment 8732272 [details]
MozReview Request: Bug 1177944 - Allow disabling reviewer deduction with a config option. r=glob

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41063/diff/2-3/

Comment 11

[Botond Ballo [:botond]]

Apologies for the churn.

Comment 12

[:glob ✱]

Comment on attachment 8732272 [details]
MozReview Request: Bug 1177944 - Allow disabling reviewer deduction with a config option. r=glob

https://reviewboard.mozilla.org/r/41063/#review38401

::: hgext/reviewboard/tests/test-specify-reviewers.t:596
(Diff revision 3)
> +
> +  changeset:  29:ec05f2b11ce8
> +  summary:    Bug 2 - awesome stuff; r?remus
> +  review:     http://$DOCKER_HOSTNAME:$HGPORT1/r/15 (draft)
> +
> +  review id:  bz://2/mynick
> +  review url: http://$DOCKER_HOSTNAME:$HGPORT1/r/12 (draft)
> +  (review requests lack reviewers; visit review url to assign reviewers)
> +
> +  publish these review requests now (Yn)?  y
> +  (published review request 12)
> +

this test doesn't pass for two reasons:
- the changeset hash is different (df9e974cc15e)
- trailing whitespace has been removed from the empty lines, which breaks the test diffs

Comment 13

[Botond Ballo [:botond]]

(In reply to Byron Jones ‹:glob› from comment #12)
> this test doesn't pass for two reasons:
> - the changeset hash is different (df9e974cc15e)
> - trailing whitespace has been removed from the empty lines, which breaks
> the test diffs

Thanks for catching that! Not sure why it was passing for me when I originally tested it...

Comment 14

[Botond Ballo [:botond]]

Comment on attachment 8732272 [details]
MozReview Request: Bug 1177944 - Allow disabling reviewer deduction with a config option. r=glob

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41063/diff/3-4/

Comment 15

[:glob ✱]

Comment on attachment 8732272 [details]
MozReview Request: Bug 1177944 - Allow disabling reviewer deduction with a config option. r=glob

https://reviewboard.mozilla.org/r/41063/#review39415

r=glob

Comment 16

[Botond Ballo [:botond]]

Thanks for the review!

Comment 17

[Botond Ballo [:botond]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/d109b7c9b0d0

Comment 18

[Botond Ballo [:botond]]

(I meant to close this when I posted the hg.m.o link.)