Closed Bug 1177946 Opened 9 years ago Closed 9 years ago

<Regression> Mozilla-Inbound-Non-PGO - TResize - WINNT 5.1 (ix) - 8.51%

Categories

(Core :: Graphics, defect)

41 Branch
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: mchang, Assigned: mchang)

References

Details

(Keywords: perf, regression, Whiteboard: [talos_regression])

From Talos emails:

Regression: Mozilla-Inbound-Non-PGO - TResize - WINNT 5.1 (ix) - 8.51% increase
-------------------------------------------------------------------------------
   Previous: avg 12.915 stddev 0.205 of 12 runs up to revision cbe9a2aea954
   New     : avg 14.014 stddev 0.231 of 12 runs since revision 5ddf0a252b08
   Change  : +1.100 (8.51% / z=5.365)
   Graph   : http://mzl.la/1CxCMlK

 * http://bugzilla.mozilla.org/show_bug.cgi?id=1162824 - Change box shadow cache to cache the colored blurred box shadow
 * http://bugzilla.mozilla.org/show_bug.cgi?id=1169044 - Fetch uses wrong referrer
 * http://bugzilla.mozilla.org/show_bug.cgi?id=1175556 - ARM64: Land final, miscellaneous changes
 * http://bugzilla.mozilla.org/show_bug.cgi?id=1155828 - Speed up box-shadow drawing by using a border-image style 

This is caused by me, in bug 1155828. This is caused because we call FillRect at [1], on a cairo backend on Windows XP. See [2].

We're ok accepting this regression. On real web pages that use box shadows, we can get up to a 25x improvement. See [3] and [4].

[1] https://dxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxBlur.cpp?from=gfxBlur.cpp&case=true#520
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1155828#c43
[3] https://bugzilla.mozilla.org/show_bug.cgi?id=1155828#c4
[4] https://bugzilla.mozilla.org/show_bug.cgi?id=1162824#c1

Joel, can we please note that we're going to accept this regression?
Flags: needinfo?(jmaher)
thanks, this is documented and we will have info on this when we uplift to Aurora next week!
Blocks: 1165349
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(jmaher)
Keywords: perf, regression
Resolution: --- → WONTFIX
Whiteboard: [talos_regression]
You need to log in before you can comment on or make changes to this bug.