1177970 - Foxfood: RunWhatsApp - Contact's profile photo has incorrect aspect ratio

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, defect)

Description

[[e-mail]]

User-Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

See screenshot

when viewing contact's profile photo on full screen, it is evident that the aspect ratio is slightly wrong.

Comment 1

[[e-mail]]

Attachment: 2015-06-26-21-09-35.png

Comment 2

[Marco Castelluccio [:marco]]

I think this should be fixed by https://github.com/mozilla/pluotsorbet/pull/1656.

Comment 3

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

Triage: The happy path is not working. Holding the next release on it. QA wanted to verify if the fix in comment 2 is correct.

Comment 4

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Johan, how do we install the latest build for the app?  As I understand the master repository for it should have that patch but I don't know how to install it from that repository.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

I've submitted a build with the fix to Marketplace, and it'll be available once bwalker approves it (which should happen today unless he's unexpectedly called away).

In the meantime, you can build the app locally:

git clone https://github.com/mozilla/pluotsorbet
cd pluotsorbet
make -f runwhatsapppreview.mk app

Then push the runwhatsapppreview/ directory to your device using WebIDE.

You'll need wget, a JDK, and TypeScript to build.  Get the JDK from Oracle <http://www.oracle.com/technetwork/java/javase/downloads/index.html>. The easiest way to install TypeScript is via npm (npm install -g typescript).

Comment 6

[Bill Walker [:bwalker] [@wfwalker]]

(In reply to Myk Melez [:myk] [@mykmelez] from comment #5)
> I've submitted a build with the fix to Marketplace, and it'll be available
> once bwalker approves it (which should happen today unless he's unexpectedly
> called away).

Just approved, apologies for the delay.

Comment 7

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

Thanks Myk for the explanations.

Comment 8

[KTucker [:KTucker][Inactive 3/4/2016]]

We are still this occur on Version 2.12.89. Contact pictures are distorted. Has the new version landed yet?

Comment 9

[KTucker [:KTucker][Inactive 3/4/2016]]

Correction to Comment 8. We are still seeing this occur on Version 2.12.89 of the RunWhatsApp on Aries.

Are we on the correct version?

Device: Aries 2.5
Build ID: 20150722124026
Gaia: b57aef5b7f52c40f88ee4c069ff722404e8e8521
Gecko: 954706e7611c
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Comment 10

[Myk Melez [:myk] [@mykmelez]]

(In reply to KTucker [:KTucker] from comment #8)
> We are still this occur on Version 2.12.89. Contact pictures are distorted.
> Has the new version landed yet?

Yes, we published it to Marketplace on July 10.


(In reply to KTucker [:KTucker] from comment #9)
> Correction to Comment 8. We are still seeing this occur on Version 2.12.89
> of the RunWhatsApp on Aries.
> 
> Are we on the correct version?

That's the version of the WhatsApp midlet, but I'd actually need to know the version of the RunWhatsApp application to be able to answer your question.  Unfortunately, I don't know how to determine that, as FxOS doesn't appear to have an interface that displays the versions of installed applications (or even one that lists installed applications, except for Settings > App Permissions).

Comment 11

[Mahendra Potharaju [:mahe]]

Kevin, 

Can you confirm if this issue still exists? If yes, please provide details Myk was looking for. 

Myk - NI'ed you, so you this gets to your list. 

Thanks.

Comment 12

[Pi Wei Cheng [:piwei] (inactive)]

(In reply to Mahendra Potharaju [:mahe] from comment #11)
> Can you confirm if this issue still exists? If yes, please provide details
> Myk was looking for. 

Yes this issue is still occurring on latest Aries build. Please read comment 10 carefully as :myk did NOT provide a way for us to tell the actual version of the app because they don't know how either.

Additional info:
This issue seems to only occur if user selects Camera when they try to set their profile photo. The bug does NOT happen if they select Gallery, or if they select Gallery > Camera when setting up their profile photo.

Tested on:
Device: Aries (runwhatsapp midlet version 2.13.4)
BuildID: 20150911152752
Gaia: 758c75ee087ea3722213ea2c185cca1d952c8a29
Gecko: 12b6c9a7fe539c9da25a5682a6b8f2dac0678bad
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

NI Naoki to find out the actual runwhatsapp version.

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

It's a pain in the butt to find the id; it's in the manifest file in a appid directory so you have to hunt and peck at all the web ids and manifest until you find the right app.

version 0.22 on 20150911151208:
shell@aries:/system/b2g/webapps/{598b3edc-04c4-4362-aaff-2381eed81341} #                                                                        <
{"name": "RunWhatsApp (Preview)", "icons": {"128": "/img/icon-128.png", "512": "/img/icon-512.png"}, "version": "0.22", "package_path": "/application.zip", "developer": {"url": "http://mozilla.org", "name": "Mozilla Apps"}, "release_notes": "", "size": 1385842}shell@aries:/system/b2g/webapps/{598b3edc-04c4-4362-aaff-2381eed81341}

It's not quite the same as piwei, having said that the issue still exists there.  I doubt anything changed between the two builds.



Myk: request that there's something in the ui to tell you the version of the midlet please.  :)
Probably having the hash being pushed as a note in the manifest might help too...

Comment 14

[Myk Melez [:myk] [@mykmelez]]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #13)
> Myk: request that there's something in the ui to tell you the version of the
> midlet please.  :)

Erm, you mean the version of the *app*, right?  I filed https://github.com/mozilla/pluotsorbet/issues/1872 on this.

Comment 15

[Mahendra Potharaju [:mahe]]

[Tracking Requested - why for this release]: As Whats App is not part of 2.5 release, removing blocker flag and adding backlog flag

Comment 16

[Myk Melez [:myk] [@mykmelez]]

As Bill Walker notes in bug 1177394, comment 24, he has directed his engineering team to stop work on RunWhatsApp in favor of our new focus on progressive web apps, so we won't have time to spend on this.