Closed Bug 1178004 Opened 5 years ago Closed 4 years ago

Remove dead code from browser-aero.css

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 41
Tracking Status
firefox39 --- wontfix
firefox40 + fixed
firefox41 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(1 file)

No description provided.
Attached patch PatchSplinter Review
I couldn't see a difference when removing this.
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Attachment #8626904 - Flags: review?(dao)
Comment on attachment 8626904 [details] [diff] [review]
Patch

Never really understood what this was good for in the first place... i.e. why we'd need an "additional hover state for the Bookmark button" on Windows 8
Attachment #8626904 - Flags: review?(dao) → review+
Keywords: checkin-needed
Blocks: 1173743
https://hg.mozilla.org/mozilla-central/rev/259dcb2a811e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Comment on attachment 8626904 [details] [diff] [review]
Patch

Approval Request Comment (for Firefox 40 /!\)
[Feature/regressing bug #]: Windows 10 work
[User impact if declined]: No visible impact, but required to uplift further windows 10 work.
[Describe test coverage new/current, TreeHerder]: on m-c
[Risks and why]: Low, CSS clean up only
[String/UUID change made/needed]: none
Attachment #8626904 - Flags: approval-mozilla-beta?
Depends on: 1179756
No longer depends on: 1179756
Depends on: 1179756
No longer depends on: 1179756
Comment on attachment 8626904 [details] [diff] [review]
Patch

Fairly simple code removal required for Windows 10 work. Beta+
Attachment #8626904 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Add a tracking flag for FF40. The patch has already landed in moz-beta.
You need to log in before you can comment on or make changes to this bug.