Last Comment Bug 1178025 - Reviews column in commit table should be flex-y
: Reviews column in commit table should be flex-y
Status: RESOLVED FIXED
:
Product: MozReview
Classification: Other
Component: General (show other bugs)
: unspecified
: Unspecified Unspecified
-- normal
: ---
Assigned To: Mike Conley (:mconley)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-06-27 11:55 PDT by Mike Conley (:mconley)
Modified: 2016-02-21 20:31 PST (History)
3 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

MozReview Requests
Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:
Show discarded requests

Attachments
MozReview Request: mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio (40 bytes, text/x-review-board-request)
2015-06-27 22:45 PDT, Mike Conley (:mconley)
mdoglio: review+
Details | Review
MozReview Request: mozreview: fix commit table borders (Bug 1178025); r?smacleod (40 bytes, text/x-review-board-request)
2015-07-16 11:33 PDT, Mauro Doglio [:mdoglio]
smacleod: review+
Details | Review

Description User image Mike Conley (:mconley) 2015-06-27 11:55:18 PDT
As the window expands and contracts, the "Reviews" column should greedily eat up space in the table. It should also have a minimum size so that the entries in the Reviews column are always somewhat visible, despite being truncate-able (since we should do text-overflow: ellipsis on the commit summaries themselves).

PoC: http://jsfiddle.net/4qrz8yav/
Comment 1 User image Mike Conley (:mconley) 2015-06-27 22:45:23 PDT
Created attachment 8626969 [details]
MozReview Request: mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio

mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio
Comment 2 User image Mike Conley (:mconley) 2015-06-27 22:46:22 PDT
https://reviewboard.mozilla.org/r/12179/#review10645

::: pylib/mozreview/mozreview/templates/mozreview/commits.html:35
(Diff revision 1)
> -      <td class="mozreview_min_length">
> +      <td class="diff mozreview_min_length">

Can probably remove mozreview_min_length

::: pylib/mozreview/mozreview/templates/mozreview/commits.html:41
(Diff revision 1)
> -      <td class="truncate_text mozreview_min_length">
> +      <td class="reviews truncate_text mozreview_min_length">

Can probably remove mozreview_min_length

::: pylib/mozreview/mozreview/templates/mozreview/commits.html:53
(Diff revision 1)
> -      <td class="mozreview_min_length">
> +      <td class="status mozreview_min_length">

Can probably remove mozreview_min_length
Comment 3 User image Mike Conley (:mconley) 2015-06-27 22:47:46 PDT
Comment on attachment 8626969 [details]
MozReview Request: mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio

mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio
Comment 4 User image Mauro Doglio [:mdoglio] 2015-06-29 07:10:46 PDT
https://reviewboard.mozilla.org/r/12177/#review10663

Hey :mconley can you please add a couple of screenshots of the new layout?
Comment 5 User image Mike Conley (:mconley) 2015-07-07 08:01:04 PDT
Comment on attachment 8626969 [details]
MozReview Request: mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio

mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio
Comment 6 User image Mike Conley (:mconley) 2015-07-07 08:01:27 PDT
https://reviewboard.mozilla.org/r/12177/#review10663

Here's a video of me flexing the table: http://www.screencast.com/t/fZkOwYJO
Comment 7 User image Mike Conley (:mconley) 2015-07-07 10:39:33 PDT
Provided the screencast I wanted to.
Comment 8 User image Mauro Doglio [:mdoglio] 2015-07-08 03:47:26 PDT
Comment on attachment 8626969 [details]
MozReview Request: mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio

https://reviewboard.mozilla.org/r/12179/#review11379

Ship It!
Comment 9 User image Mauro Doglio [:mdoglio] 2015-07-08 03:47:49 PDT
Thanks :mconley!
Comment 11 User image Mauro Doglio [:mdoglio] 2015-07-16 11:33:04 PDT
Created attachment 8634844 [details]
MozReview Request: mozreview: fix commit table borders (Bug 1178025); r?smacleod

mozreview: fix commit table borders (Bug 1178025); r?smacleod
Comment 12 User image Steven MacLeod [:smacleod] 2015-07-16 11:36:38 PDT
Comment on attachment 8634844 [details]
MozReview Request: mozreview: fix commit table borders (Bug 1178025); r?smacleod

https://reviewboard.mozilla.org/r/13465/#review12075

Ship It!

Note You need to log in before you can comment on or make changes to this bug.