1178025 - Reviews column in commit table should be flex-y

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

As the window expands and contracts, the "Reviews" column should greedily eat up space in the table. It should also have a minimum size so that the entries in the Reviews column are always somewhat visible, despite being truncate-able (since we should do text-overflow: ellipsis on the commit summaries themselves).

PoC: http://jsfiddle.net/4qrz8yav/

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio

mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio

Comment 2

[Mike Conley (:mconley) (:⚙️)]

https://reviewboard.mozilla.org/r/12179/#review10645

::: pylib/mozreview/mozreview/templates/mozreview/commits.html:35
(Diff revision 1)
> -      <td class="mozreview_min_length">
> +      <td class="diff mozreview_min_length">

Can probably remove mozreview_min_length

::: pylib/mozreview/mozreview/templates/mozreview/commits.html:41
(Diff revision 1)
> -      <td class="truncate_text mozreview_min_length">
> +      <td class="reviews truncate_text mozreview_min_length">

Can probably remove mozreview_min_length

::: pylib/mozreview/mozreview/templates/mozreview/commits.html:53
(Diff revision 1)
> -      <td class="mozreview_min_length">
> +      <td class="status mozreview_min_length">

Can probably remove mozreview_min_length

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8626969 [details]
MozReview Request: mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio

mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio

Comment 4

[Mauro Doglio [:mdoglio]]

https://reviewboard.mozilla.org/r/12177/#review10663

Hey :mconley can you please add a couple of screenshots of the new layout?

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8626969 [details]
MozReview Request: mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio

mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio

Comment 6

[Mike Conley (:mconley) (:⚙️)]

https://reviewboard.mozilla.org/r/12177/#review10663

Here's a video of me flexing the table: http://www.screencast.com/t/fZkOwYJO

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Provided the screencast I wanted to.

Comment 8

[Mauro Doglio [:mdoglio]]

Comment on attachment 8626969 [details]
MozReview Request: mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio

https://reviewboard.mozilla.org/r/12179/#review11379

Ship It!

Comment 9

[Mauro Doglio [:mdoglio]]

Thanks :mconley!

Comment 10

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/52f4ade3ec72

Comment 11

[Mauro Doglio [:mdoglio]]

Attachment: MozReview Request: mozreview: fix commit table borders (Bug 1178025); r?smacleod

mozreview: fix commit table borders (Bug 1178025); r?smacleod

Comment 12

[Steven MacLeod [:smacleod]]

Comment on attachment 8634844 [details]
MozReview Request: mozreview: fix commit table borders (Bug 1178025); r?smacleod

https://reviewboard.mozilla.org/r/13465/#review12075

Ship It!