The default bug view has changed. See this FAQ.

Reviews column in commit table should be flex-y

RESOLVED FIXED

Status

MozReview
General
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

As the window expands and contracts, the "Reviews" column should greedily eat up space in the table. It should also have a minimum size so that the entries in the Reviews column are always somewhat visible, despite being truncate-able (since we should do text-overflow: ellipsis on the commit summaries themselves).

PoC: http://jsfiddle.net/4qrz8yav/
Created attachment 8626969 [details]
MozReview Request: mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio

mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio
Attachment #8626969 - Flags: review?(mdoglio)
https://reviewboard.mozilla.org/r/12179/#review10645

::: pylib/mozreview/mozreview/templates/mozreview/commits.html:35
(Diff revision 1)
> -      <td class="mozreview_min_length">
> +      <td class="diff mozreview_min_length">

Can probably remove mozreview_min_length

::: pylib/mozreview/mozreview/templates/mozreview/commits.html:41
(Diff revision 1)
> -      <td class="truncate_text mozreview_min_length">
> +      <td class="reviews truncate_text mozreview_min_length">

Can probably remove mozreview_min_length

::: pylib/mozreview/mozreview/templates/mozreview/commits.html:53
(Diff revision 1)
> -      <td class="mozreview_min_length">
> +      <td class="status mozreview_min_length">

Can probably remove mozreview_min_length
Comment on attachment 8626969 [details]
MozReview Request: mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio

mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio
https://reviewboard.mozilla.org/r/12177/#review10663

Hey :mconley can you please add a couple of screenshots of the new layout?
Flags: needinfo?(mconley)
Comment on attachment 8626969 [details]
MozReview Request: mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio

mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio
https://reviewboard.mozilla.org/r/12177/#review10663

Here's a video of me flexing the table: http://www.screencast.com/t/fZkOwYJO
Provided the screencast I wanted to.
Flags: needinfo?(mconley)
Comment on attachment 8626969 [details]
MozReview Request: mozreview: make reviews and reviewers columns in commits table more flex-y (bug 1178025); r?mdoglio

https://reviewboard.mozilla.org/r/12179/#review11379

Ship It!
Attachment #8626969 - Flags: review?(mdoglio) → review+
Thanks :mconley!
https://hg.mozilla.org/hgcustom/version-control-tools/rev/52f4ade3ec72
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Created attachment 8634844 [details]
MozReview Request: mozreview: fix commit table borders (Bug 1178025); r?smacleod

mozreview: fix commit table borders (Bug 1178025); r?smacleod
Attachment #8634844 - Flags: review?(smacleod)
Comment on attachment 8634844 [details]
MozReview Request: mozreview: fix commit table borders (Bug 1178025); r?smacleod

https://reviewboard.mozilla.org/r/13465/#review12075

Ship It!
Attachment #8634844 - Flags: review?(smacleod) → review+
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.