Closed Bug 1178072 Opened 5 years ago Closed 5 years ago

Location view domain highlighting could be "translated" to VoiceOver using voice pitch

Categories

(Firefox for iOS :: Browser, enhancement)

All
iOS 8
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dusek, Assigned: dusek)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review
BrowserLocationView.highlightDomain could use UIAccessibilitySpeechAttributePitch to lower the voice pitch on the gray (dimmer) parts of the URL. NSMutableAttributedString.colorSubstring extension method could get a similar sibling method for UIAccessibilitySpeechAttributePitch, which would then be used just like the former in the highlighting code.
Status: NEW → ASSIGNED
Attached file Pull Request
Attachment #8626988 - Flags: review?(sarentz)
Attachment #8626988 - Flags: review?(sarentz) → review?(bnicholson)
Comment on attachment 8626988 [details] [review]
Pull Request

Interesting, looks good! Do other browsers do this?
Attachment #8626988 - Flags: review?(bnicholson) → review+
(In reply to Brian Nicholson (:bnicholson) from comment #2)

> Interesting, looks good! Do other browsers do this?

Well, Safari does not do highlighting in url bar, it does not even show anything apart from the domain name.

Chrome does change the highlighting for things outside the domain, but does not translate it into pitch change.

We are already doing similar thing for read items in Reading List table, where gray for read items translated into lower pitch.

I am not aware of an example of any other app doing this. This might well be Firefox for iOS pushing the envelope (raising the bar for iOS accessible apps).
:bnicholson I guess this is ready for merge.
Flags: needinfo?(bnicholson)
Nice, Firefox first! :D

https://github.com/mozilla/firefox-ios/commit/09395a164cdaabc17dc8fd845648e1f6ce4d9931
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: needinfo?(bnicholson)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.