1178072 - Location view domain highlighting could be "translated" to VoiceOver using voice pitch

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, enhancement)

Description

[Boris Dušek]

BrowserLocationView.highlightDomain could use UIAccessibilitySpeechAttributePitch to lower the voice pitch on the gray (dimmer) parts of the URL. NSMutableAttributedString.colorSubstring extension method could get a similar sibling method for UIAccessibilitySpeechAttributePitch, which would then be used just like the former in the highlighting code.

Comment 1

[Boris Dušek]

Attachment: Pull Request

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8626988 [details] [review]
Pull Request

Interesting, looks good! Do other browsers do this?

Comment 3

[Boris Dušek]

(In reply to Brian Nicholson (:bnicholson) from comment #2)

> Interesting, looks good! Do other browsers do this?

Well, Safari does not do highlighting in url bar, it does not even show anything apart from the domain name.

Chrome does change the highlighting for things outside the domain, but does not translate it into pitch change.

We are already doing similar thing for read items in Reading List table, where gray for read items translated into lower pitch.

I am not aware of an example of any other app doing this. This might well be Firefox for iOS pushing the envelope (raising the bar for iOS accessible apps).

Comment 4

[Boris Dušek]

:bnicholson I guess this is ready for merge.

Comment 5

[Brian Nicholson (:bnicholson)]

Nice, Firefox first! :D

https://github.com/mozilla/firefox-ios/commit/09395a164cdaabc17dc8fd845648e1f6ce4d9931