Closed Bug 1178081 Opened 9 years ago Closed 9 years ago

[b2g][Device Info] Show actual device information in settings

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S2 (10Jul)
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: afarden, Assigned: afarden)

References

Details

Attachments

(4 files)

Patch to gecko
1.78 KB, patch
fabrice
: review+
jj.evelyn
: feedback+
Details | Diff | Splinter Review
Patch to gaia
46 bytes, text/x-github-pull-request
jj.evelyn
: review+
Details | Review
Before (png)
203.12 KB, image/png
Details
After (png)
201.90 KB, image/png
Details 
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.81 Safari/537.36

Steps to reproduce:

I wanted to know something about my device, but all it said was 'qcom'.
Summary: [b2g][Device Info] So actual device information in settings → [b2g][Device Info] Show actual device information in settings
Attached patch Patch to gecko — — Splinter Review 

    
    

    
  

      
      
      
      

        Attached file
          
        Patch to gaia
        — 
      

    


  

    
    

    
  

      
      
      
      

        Attached image
          
        Before (png)
        — 
      

    


  

    
    

    
  

      
      
      
      

        Attached image
          
        After (png)
        — 
      

    


  

    
    

    
  
Isn't it nice to actually know something about the device?
Flags: needinfo?(lissyx+mozillians)

    
    

    
  
I do think this is very useful but I'm not qualified to stamp it :)
Flags: needinfo?(lissyx+mozillians)

    
    

    
  
Evelyn, do you have anything against this ?
Flags: needinfo?(ehung)

    
    

    
  
+1 on a Sony Xperia Z3 (which I only know because of the box). Would be great to know specs too, like front and back camera resolution (back camera has resolution printed on the device)...if possible.

    
    

    
  
I don't have strong opinion here so I guess it's fine to add fields. Ping UX for input.
Flags: needinfo?(ehung) → needinfo?(hhsu)

    
    

    
  
From a UX standpoint, it is much easier for user to understand "Xperia T2 Ultra" compare to "yukun". So I am fine with adding these fields. Thanks
Flags: needinfo?(hhsu)

    
    

    
  
Comment on attachment 8626996 [details] [diff] [review]
Patch to gecko

direct to mwu for review.

        Attachment #8626996 -
        Flags: review?(mwu)

        Attachment #8626996 -
        Flags: feedback+

    
  

        Attachment #8626997 -
        Flags: review+

        Attachment #8626996 -
        Flags: review?(mwu) → review+

    
  
Assignee: nobody → adam
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/68fdf881151b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox42:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S2 (10Jul)
Depends on: 1181656

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: