1178129 - Long-press dialog should truncate URL

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Richard Newman [:rnewman]]

Attachment: 2015-06-27 20.59.10.png

See screenshot for the behavior long-pressing a Yahoo image search result.

Comment 1

[Bryan Munar (:bkmunar)]

how would you like this to be done rnewman? (in terms of just capping the url at a specific character count, etc.)

Comment 2

[allenngn]

Attachment: Pull request

Comment 3

[Richard Newman [:rnewman]]

Some widgets will do this automatically. If this alert doesn't, then at least break this functionality out into an extension on String. And use "…" not "...".

Over to someone who's not on PTO for the next step, though!

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 8629612 [details]
Pull request

Thanks for the patch! See comments earlier in the bug.

Comment 5

[Karim Benhmida [:karim]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/724

UIAlertController doesn't truncate the title out of the box, so I wrote a String extension for that. I tried "…" instead of "..." first, but for some reason, a line break was appended after the "…" which didn't look nice (*In the UI*, not as a \n or \r character in the string)

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8633055 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/724

Looking much better. Let's get some tests and fix those off-by-one errors :)

Comment 7

[Karim Benhmida [:karim]]

Fixed those errors and added tests. I also left screenshots w/ 3 dots vs ellipsis on Github.

Comment 8

[Richard Newman [:rnewman]]

If I had to guess, I'd say you want

http://www.fileformat.info/info/unicode/char/2060/index.htm

to tell UIKit not to break there.

That is, the string should be:

"\u{2060}…\u{2060}"

Give that a shot?

Comment 9

[Karim Benhmida [:karim]]

(In reply to Richard Newman [:rnewman] from comment #8)
> If I had to guess, I'd say you want
> 
> http://www.fileformat.info/info/unicode/char/2060/index.htm
> 
> to tell UIKit not to break there.
> 
> That is, the string should be:
> 
> "\u{2060}…\u{2060}"
> 
> Give that a shot?

Yes that's exactly what I want. Worked like a charm. I pushed the changes on Github.

Comment 10

[Richard Newman [:rnewman]]

Comment on attachment 8633055 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/724

Merged https://github.com/mozilla/firefox-ios/commit/be8fe25077c18c3e8d39bbc85d62e62a0237088b.