[FTU] Convert value selector usage to use gaia radio

RESOLVED FIXED in FxOS-S2 (10Jul)

Status

Firefox OS
Gaia::First Time Experience
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

unspecified
FxOS-S2 (10Jul)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
This is for web component conversion and will allow us to remove switches.css from FTU.
(Assignee)

Comment 1

3 years ago
Created attachment 8627064 [details] [review]
[Pull Request] Convert language panel switch to use gaia-radio
(Assignee)

Comment 2

3 years ago
Comment on attachment 8627064 [details] [review]
[Pull Request] Convert language panel switch to use gaia-radio

Sam - this will finally allow us to kill switches.css usage in FTU by moving the checkmark style into the gaia-radio component. I think we should probably just use the standard circular styles, but let's preserve the style for now and can remove it later after checking with UX. Please take a look and let me know what you think, thanks!
Attachment #8627064 - Flags: review?(sfoster)
Comment on attachment 8627064 [details] [review]
[Pull Request] Convert language panel switch to use gaia-radio

Looks good to me - thanks for doing this. I ran through with/without sim card and network, in LRT and RTL and didn't spot any issues. Bonus points for net LOC reduction!
Attachment #8627064 - Flags: review?(sfoster) → review+
(Assignee)

Comment 4

3 years ago
Thanks for the review. In master: https://github.com/mozilla-b2g/gaia/commit/26b1ab95da31bd8899c181c65bbce2b706c68d5e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S2 (10Jul)
You need to log in before you can comment on or make changes to this bug.