1178154 - move ShutdownLeaks and LSANLeaks from automationutils to mochitest

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Julien Pagès (:parkouss)]

So it seems that those classes are only used by mochitest. I propose to just move them in mochitest - at least for now.

https://dxr.mozilla.org/mozilla-central/search?q=LSANLeaks&case=true&redirect=true
https://dxr.mozilla.org/mozilla-central/search?q=ShutdownLeaks+ext%3Apy&case=true

Comment 1

[Julien Pagès (:parkouss)]

I first pushed to try, hopefully you will like the change here. :)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd42e533f0f3

Comment 2

[Julien Pagès (:parkouss)]

So I broke mochitest tests on the last one. I added the new file in the moz.build file:

https://hg.mozilla.org/try/diff/02d494dc55d5/testing/mochitest/moz.build

And it looks good now (still waiting for B2G ICS Emulator opt that got busted, but so far so good)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=02d494dc55d5

Comment 3

[Julien Pagès (:parkouss)]

Attachment: MozReview Request: Bug 1178154 - move ShutdownLeaks and LSANLeaks from automationutils to mochitest. r?jgriffin

Bug 1178154 - move ShutdownLeaks and LSANLeaks from automationutils to mochitest. r?jgriffin

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8627279 [details]
MozReview Request: Bug 1178154 - move ShutdownLeaks and LSANLeaks from automationutils to mochitest. r?jgriffin

https://reviewboard.mozilla.org/r/12199/#review10689

Thanks!

Comment 5

[Julien Pagès (:parkouss)]

You're welcome. :)

:Ms2Ger proposed that I fix the indentation in the same patch. So I did this (using autopep8) and try is running:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9c52709abcc

So if all is green and if you prefer the updated version, i can land it!

Comment 6

[Jonathan Griffin (:jgriffin)]

Yes, +1 to fixing the indentation.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/604815d78ad9

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/604815d78ad9