[Settings] Define Battery using new syntax provided by Observable

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: arthurcc, Assigned: arthurcc)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Define the module using new syntax.
Created attachment 8627093 [details]
link to https://github.com/mozilla-b2g/gaia/pull/30736

EJ, could you help review this simple patch? Thanks!

In addition to the syntax change, I also included some common modules in main.js so that we no longer need to exclude them in require.js.
Attachment #8627093 - Flags: review?(eragonj+moz)
Comment on attachment 8627093 [details]
link to https://github.com/mozilla-b2g/gaia/pull/30736

Thanks Arthur !! This patch looks nice, r+++.
Attachment #8627093 - Flags: review?(eragonj+moz) → review+
Depends on: 1178229
No longer depends on: 1178229
Summary: [Settings][meta] Define Battery using new syntax provided by Observable → [Settings] Define Battery using new syntax provided by Observable
Thanks, EJ!

master: 399ac33c9a44d8988f1429e761063f04ebd3c917

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.