1178172 - Fix all compile errors in dom/base on non-unified build

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: Fix

I've been suffering from compile error each time I add (a) file(s) into dom/base.
So I'm going to fix all errors at least in dom/base.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Pushed a try now.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=72f3c6184443

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8627096 [details] [diff] [review]
Fix

:baku, could you please review this?

B2G ICS opt/debug and B2G L opt failed the the try result, but it seems OK because those platforms fail on other try runs too.

An example: https://treeherder.mozilla.org/#/jobs?repo=try&revision=de83156d7de9

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8627096 [details] [diff] [review]
Fix

Clearing review request due to a crash on a web-platform test </html/semantics/embedded-content/the-img-element/current-pixel-density/basic.html>

Comment 4

[Nathan Froyd [:froydnj]]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #3)
> Clearing review request due to a crash on a web-platform test
> </html/semantics/embedded-content/the-img-element/current-pixel-density/
> basic.html>

This failure is not your fault.  See https://groups.google.com/forum/#!topic/mozilla.dev.platform/Ph5EusVcjJA

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Nathan, thanks for the info.
I was very confused, and suspected there might be a hidden serious bug in dom/base related to namespace mistake or something...

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Attachment: Fix v2

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3bc85df3fdb

I did a try for safety.  There are all known oranges.

This patch is slightly different from the previous one, just removed a modification in dom/workers/ file (WorkerScope.cpp).

I should note about the change in ipc/glue/BackgroundUtils.h in the patch. Actually this file does not sit in dom/base but nsHostObjectURI.cpp and nsJSEnvironment.cpp include the header file so we need to fix the header too.

Comment 7

[Andrea Marchesini [:baku]]

Comment on attachment 8628061 [details] [diff] [review]
Fix v2

Review of attachment 8628061 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/PerformanceEntry.cpp
@@ +6,5 @@
>  
>  #include "PerformanceEntry.h"
>  #include "nsIURI.h"
>  #include "mozilla/dom/PerformanceEntryBinding.h"
> +#include "MainThreadUtils.h"

can you sort these headers in this way:

PerformanceEntry.h
MainThreadUtils.h
mozilla/dom//PerforamnceEntryBinding.h
nsIURI.h

::: dom/base/PerformanceEntry.h
@@ +7,5 @@
>  #ifndef mozilla_dom_PerformanceEntry_h___
>  #define mozilla_dom_PerformanceEntry_h___
>  
>  #include "nsDOMNavigationTiming.h"
> +#include "nsWrapperCache.h"

alphabetic order: nsString.h before nsWrapperCache.h

::: dom/base/PerformanceMark.cpp
@@ +5,5 @@
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  #include "PerformanceMark.h"
>  #include "mozilla/dom/PerformanceMarkBinding.h"
> +#include "MainThreadUtils.h"

move it to line 8

::: dom/base/PerformanceMeasure.cpp
@@ +5,5 @@
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  #include "PerformanceMeasure.h"
>  #include "mozilla/dom/PerformanceMeasureBinding.h"
> +#include "MainThreadUtils.h"

move to line 8.

::: dom/base/nsDOMMutationObserver.cpp
@@ +341,5 @@
>    Disconnect(true);
>  }
>  
>  void
> +nsAnimationReceiver::RecordAnimationMutation(mozilla::dom::Animation* aAnimation,

what about adding:

using mozilla::dom::Animation at the top and then use |Animation| everywhere?

::: ipc/glue/BackgroundUtils.h
@@ +11,5 @@
>  #include "nsCOMPtr.h"
>  #include "nscore.h"
>  
>  class nsIPrincipal;
> +class nsILoadInfo;

here we want an alphabetic order. invert these 2 lines.

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Attachment: Fix v3

Addressed all comments.

Thanks!

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4eade4f528d4

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4eade4f528d4