make BroadcastChannel CC skippable

RESOLVED FIXED in Firefox 42

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: baku, Assigned: baku)

Tracking

Trunk
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8627179 [details] [diff] [review]
bc.patch

I guess we can use this method somewhere else in case you like it.
Attachment #8627179 - Flags: review?(bugs)
Comment on attachment 8627179 [details] [diff] [review]
bc.patch

This wouldn't compile because of isBlack isn't defined anywhere.
And perhaps call the new method IsCertainlyAliveForCC().
Attachment #8627179 - Flags: review?(bugs) → review-
Summary: maybe BroadcastChannel CC skipable → make BroadcastChannel CC skippable
(Assignee)

Comment 3

3 years ago
Created attachment 8627194 [details] [diff] [review]
bc.patch
Attachment #8627179 - Attachment is obsolete: true
Attachment #8627194 - Flags: review?(bugs)
Comment on attachment 8627194 [details] [diff] [review]
bc.patch

>+  // Implement this method if your call can be skippable instead having your own
odd comment "if your call"


>+  // CAN_BE_SKIP macros.
There are no CAN_BE_SKIP macros, they are CAN_SKIP


Fix those comments.
Attachment #8627194 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/96d1f2a80e37
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.