Closed Bug 1178307 Opened 9 years ago Closed 9 years ago

Darker Hello icon needed for Windows 10 toolbar

Categories

(Firefox :: Theme, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 42
Tracking Status
firefox40 --- verified
firefox41 --- verified
firefox42 --- verified

People

(Reporter: jaws, Assigned: jaws)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

Darker toolbar icons for Windows 10 were added in bug 1166930, but the Hello icon wasn't updated.

needinfo for updated Hello sprite.
Flags: needinfo?(shorlander)
Priority: -- → P1
Blocks: windows-10
This bug is preventing bug 1166930 from being uplifted into 40, as they want to uplift both at the same time. Are there any updates?
Flags: needinfo?(jaws)
We still need icons for this from UX. Redirecting needinfo...
Flags: needinfo?(philipp)
Flags: needinfo?(madhava)
Flags: needinfo?(jaws)
Attached image toolbar-win10.png
Flags: needinfo?(shorlander)
Flags: needinfo?(philipp)
Flags: needinfo?(madhava)
Flags: needinfo?(jaws)
Blocks: theme-win10
Attached patch PatchSplinter Review
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)
Attachment #8633618 - Flags: review?(dao)
Attachment #8633618 - Flags: review?(dao) → review+
Approval Request Comment
[Feature/regressing bug #]: Windows 10 icons
[User impact if declined]: Windows 10 will have an off-color Hello icon
[Describe test coverage new/current, TreeHerder]: simple icon replacement
[Risks and why]: none
[String/UUID change made/needed]: none
Attachment #8634233 - Flags: approval-mozilla-beta?
Attachment #8634233 - Flags: approval-mozilla-aurora?
Comment on attachment 8634233 [details] [diff] [review]
Patch for Aurora41 and Beta40

Simple icon replacement
Attachment #8634233 - Flags: approval-mozilla-beta?
Attachment #8634233 - Flags: approval-mozilla-beta+
Attachment #8634233 - Flags: approval-mozilla-aurora?
Attachment #8634233 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/097c19658698
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Flags: qe-verify+
QA Contact: cornel.ionce
This is now fixed on Windows 10 64-bit using:
- latest Nightly, build ID: 20150720030213;
- latest Aurora, build ID: 20150720004006;
- Firefox 40 beta 6, build ID: 20150720220238.
You need to log in before you can comment on or make changes to this bug.