Closed
Bug 1178307
Opened 9 years ago
Closed 9 years ago
Darker Hello icon needed for Windows 10 toolbar
Categories
(Firefox :: Theme, defect, P1)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 42
People
(Reporter: jaws, Assigned: jaws)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
751 bytes,
image/png
|
Details | |
1.57 KB,
image/png
|
Details | |
9.36 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
9.41 KB,
patch
|
kglazko
:
approval-mozilla-aurora+
kglazko
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Darker toolbar icons for Windows 10 were added in bug 1166930, but the Hello icon wasn't updated. needinfo for updated Hello sprite.
Flags: needinfo?(shorlander)
Assignee | ||
Updated•9 years ago
|
Priority: -- → P1
Updated•9 years ago
|
Blocks: windows-10
Comment 1•9 years ago
|
||
This bug is preventing bug 1166930 from being uplifted into 40, as they want to uplift both at the same time. Are there any updates?
Flags: needinfo?(jaws)
Assignee | ||
Comment 2•9 years ago
|
||
We still need icons for this from UX. Redirecting needinfo...
Flags: needinfo?(philipp)
Flags: needinfo?(madhava)
Flags: needinfo?(jaws)
Comment 3•9 years ago
|
||
Flags: needinfo?(shorlander)
Comment 4•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(philipp)
Flags: needinfo?(madhava)
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(jaws)
Updated•9 years ago
|
Blocks: theme-win10
Assignee | ||
Comment 5•9 years ago
|
||
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)
Attachment #8633618 -
Flags: review?(dao)
Updated•9 years ago
|
Attachment #8633618 -
Flags: review?(dao) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Approval Request Comment [Feature/regressing bug #]: Windows 10 icons [User impact if declined]: Windows 10 will have an off-color Hello icon [Describe test coverage new/current, TreeHerder]: simple icon replacement [Risks and why]: none [String/UUID change made/needed]: none
Attachment #8634233 -
Flags: approval-mozilla-beta?
Attachment #8634233 -
Flags: approval-mozilla-aurora?
Comment 8•9 years ago
|
||
Comment on attachment 8634233 [details] [diff] [review] Patch for Aurora41 and Beta40 Simple icon replacement
Attachment #8634233 -
Flags: approval-mozilla-beta?
Attachment #8634233 -
Flags: approval-mozilla-beta+
Attachment #8634233 -
Flags: approval-mozilla-aurora?
Attachment #8634233 -
Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/097c19658698
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment 10•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/f98edcdf3c24
status-firefox40:
--- → fixed
Comment 11•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/4cc8a471f7ea
status-firefox41:
--- → fixed
Updated•9 years ago
|
Flags: qe-verify+
QA Contact: cornel.ionce
Comment 12•9 years ago
|
||
This is now fixed on Windows 10 64-bit using: - latest Nightly, build ID: 20150720030213; - latest Aurora, build ID: 20150720004006; - Firefox 40 beta 6, build ID: 20150720220238.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•