Closed Bug 1178339 Opened 6 years ago Closed 6 years ago

Account for service workers separately in WorkerDomainInfo

Categories

(Core :: DOM: Service Workers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Blocks: 1148935
Comment on attachment 8627215 [details] [diff] [review]
Account for service workers separately in WorkerDomainInfo

Review of attachment 8627215 [details] [diff] [review]:
-----------------------------------------------------------------

While this patch separates the counting, it doesn't update the RuntimeService so that SWs are not counted towards the quota of active workers so that dedicated workers don't get queued. GetActiveCount() should ignore the SW count if you want that. I assume you're going to follow with some other changes for that.
Attachment #8627215 - Flags: review?(nsm.nikhil) → review+
Oh, you're right.  I meant to do that actually in this patch, but I will submit a new one for that.
Filed bug 1179489 as a follow-up.
This is unrelated.
Flags: needinfo?(ehsan)
https://hg.mozilla.org/mozilla-central/rev/687e3629e5d8
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.