1178339 - Account for service workers separately in WorkerDomainInfo

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Comment 1

[(no longer active)]

Attachment: Account for service workers separately in WorkerDomainInfo

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8627215 [details] [diff] [review]
Account for service workers separately in WorkerDomainInfo

Review of attachment 8627215 [details] [diff] [review]:
-----------------------------------------------------------------

While this patch separates the counting, it doesn't update the RuntimeService so that SWs are not counted towards the quota of active workers so that dedicated workers don't get queued. GetActiveCount() should ignore the SW count if you want that. I assume you're going to follow with some other changes for that.

Comment 3

[(no longer active)]

Oh, you're right.  I meant to do that actually in this patch, but I will submit a new one for that.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0cfb1a32d09

Comment 5

[(no longer active)]

Filed bug 1179489 as a follow-up.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This intermittent failure seemed to spike around the time this (and bug 1163410) landed on inbound: https://treeherder.mozilla.org/logviewer.html#?job_id=11283524&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/a067d2f467ea

Comment 7

[(no longer active)]

This is unrelated.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/687e3629e5d8

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/687e3629e5d8