1178363 - clean up nsTimerImpl's external interface a bit

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: make nsTimerImpl::SetDelayInternal a private method

Nothing outside nsTimerImpl uses it, and with a name like
"SetDelayInternal", nothing should.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: make nsTimerImpl::Fire a private method

This method is only called by nsTimerEvent, which is an implementation
detail of nsTimerImpl.

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: make nsTimerImpl::DispatchTracedTask a private method

DispatchTracedTask is only called by the timer thread, which is already
able to access private members of nsTimerImpl; there's no reason for
DispatchTracedTask to be public.

Comment 4

[Nathan Froyd [:froydnj]]

Attachment: make nsTimerImpl::PostTimerEvent a private method

PostTimerEvent is only called by the timer thread, which is already able
to access private members of nsTimerImpl; there's no reason for
PostTimerEvent to be public.

Comment 5

[Biru [:poiru]]

Comment on attachment 8627254 [details] [diff] [review]
make nsTimerImpl::DispatchTracedTask a private method

Review of attachment 8627254 [details] [diff] [review]:
-----------------------------------------------------------------

This patch seems to have been obsoleted by http://hg.mozilla.org/mozilla-central/rev/ce36885ea160

Comment 6

[Nathan Froyd [:froydnj]]

Attachment: make MOZ_TASK_TRACER-dependent bits of nsTimerImpl private

Noticed the problem with DispatchTracedTask after rebasing.

GetTracedTask() is only called from nsTimerImpl itself, so it doesn't
need to be public.  GetTLSTraceInfo() is called from the timer thread,
which has access to our private members already.

Comment 7

[Nathan Froyd [:froydnj]]

Attachment: make nsTimerImpl::GetGeneration a private method

Since GetGeneration() is only called by nsTimerEvent, it doesn't need to
be public.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d8477bd43531
https://hg.mozilla.org/integration/mozilla-inbound/rev/782ec69db4e3
https://hg.mozilla.org/integration/mozilla-inbound/rev/3eb2d9a5bfe5
https://hg.mozilla.org/integration/mozilla-inbound/rev/0edaf3f59b4d
https://hg.mozilla.org/integration/mozilla-inbound/rev/0fb582f7086d

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d8477bd43531
https://hg.mozilla.org/mozilla-central/rev/782ec69db4e3
https://hg.mozilla.org/mozilla-central/rev/3eb2d9a5bfe5
https://hg.mozilla.org/mozilla-central/rev/0edaf3f59b4d
https://hg.mozilla.org/mozilla-central/rev/0fb582f7086d