Closed Bug 1178468 Opened 9 years ago Closed 9 years ago

Change use of cookie interface from nsiCookie to nsiCookie2

Categories

(Remote Protocol :: Marionette, defect)

Product:
Remote Protocol
Component:
Marionette
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: automatedtester, Assigned: automatedtester)

Details

(Keywords: pi-marionette-server, pi-marionette-spec)

Attachments

(2 files)

MozReview Request: Bug 1178468: rename marionette cookie test methods to be more pythonic. r?jgriffin
40 bytes, text/x-review-board-request
jgriffin
: review+
Details
MozReview Request: Bug 1178468 - Update marionette cookie support to use nsICookie2. r?jgriffin
40 bytes, text/x-review-board-request
jgriffin
: review+
Details 
THis will allow us to handle httpOnly cookies better and make us more compliant with the specification.
Bug 1178468: rename marionette cookie test methods to be more pythonic. r?jgriffin
Attachment #8634455 - Flags: review?(jgriffin)
Bug 1178468 - Update marionette cookie support to use nsICookie2. r?jgriffin

This allows us to return httpOnly key when doing getCookie and serialising the result

Details in http://w3c.github.io/webdriver/webdriver-spec.html#dfn-serialized-cookie
Attachment #8634456 - Flags: review?(jgriffin)
Comment on attachment 8634456 [details]
MozReview Request: Bug 1178468 - Update marionette cookie support to use nsICookie2. r?jgriffin

https://reviewboard.mozilla.org/r/13397/#review12071

Ship It!
Attachment #8634456 - Flags: review?(jgriffin) → review+
Comment on attachment 8634455 [details]
MozReview Request: Bug 1178468: rename marionette cookie test methods to be more pythonic. r?jgriffin

https://reviewboard.mozilla.org/r/13395/#review12073

Ship It!
Attachment #8634455 - Flags: review?(jgriffin) → review+
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/9bacd1d8c35b7d07cebbf5ab50ce06b16d3e6329
changeset:  9bacd1d8c35b7d07cebbf5ab50ce06b16d3e6329
user:       David Burns <dburns@mozilla.com>
date:       Tue Jul 07 20:57:57 2015 +0100
description:
Bug 1178468: rename marionette cookie test methods to be more pythonic. r=jgriffin

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/9659b29558ddeb8a8ddbdfddb7298a0768bdc2b2
changeset:  9659b29558ddeb8a8ddbdfddb7298a0768bdc2b2
user:       David Burns <dburns@mozilla.com>
date:       Wed Jul 15 23:51:51 2015 +0100
description:
Bug 1178468 - Update marionette cookie support to use nsICookie2. r=jgriffin

This allows us to return httpOnly key when doing getCookie and serialising the result

Details in http://w3c.github.io/webdriver/webdriver-spec.html#dfn-serialized-cookie
https://hg.mozilla.org/mozilla-central/rev/9bacd1d8c35b
https://hg.mozilla.org/mozilla-central/rev/9659b29558dd
Assignee: nobody → dburns
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: