Closed Bug 1178474 Opened 10 years ago Closed 10 years ago

Refactor Treeherder-client to have a common function for calling various endpoints

Categories

(Tree Management Graveyard :: Treeherder: Client Libraries, defect)

Product:
Tree Management Graveyard
Component:
Treeherder: Client Libraries
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: vaibhav1994, Assigned: vaibhav1994)

Details

Attachments

(1 file)

github-pr
46 bytes, text/x-github-pull-request
wlach
: review+
Details | Review
Right now we are having requests call in various methods which leads to duplicate code. Instead we can call a single function to call all api endpoints. I'll take this one.
Attached file github-pr —
Attachment #8627434 - Flags: review?(wlachance)
Comment on attachment 8627434 [details] [review] github-pr Looks good. I'd like to see one tweak before this goes in, see PR
Attachment #8627434 - Flags: review?(wlachance) → review+
Updated! William, could you merge this in?
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/096560caf59c5ad8b4126941d98ba96cd679e22c Bug 1178474 - Have a common function for calling various endpoints. https://github.com/mozilla/treeherder/commit/3b5a9032dad0c2ad1aa83e38d2fb57e100a7f30e Merge pull request #688 from vaibhavmagarwal/refactor Bug 1178474 - Have a common function for calling various endpoints.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: