1178492 - ISE Revision Dashboard

Status: RESOLVED WORKSFORME

(developer.mozilla.org Graveyard :: General, defect)

Description

[Florian Scholz (Open Web Docs)]

What did you do?
================
https://developer.mozilla.org/en-US/dashboards/revisions

What happened?
==============
Internal Server Error

What should have happened?
==========================
No ISE.

Is there anything else we should know?
======================================
Seems to be working for logged-out users.

Logged-in users can see details about user bans, so I assume it is something with that.

Comment 1

[Luke Crouch [:groovecoder]]

Only affects super-users, so a temporary work-around is to use the revision dashboard in a private browsing window.

For some reason a revision creator is missing a UserProfile ... not sure what caused it but I can fix ...

Comment 2

[Luke Crouch [:groovecoder]]

https://github.com/mozilla/kuma/pull/3292

Comment 3

[Luke Crouch [:groovecoder]]

I made an after-hours fix for this since the rev dashboard is used for spam patrol and we've been getting a spike in spam recently.

I tried some things in a "rev-dash-ise-hotfix" branch [1], but in the end I just restored an empty UserProfile object to the banned user account causing this error.

:jezdez - The real fix to prevent this in the future seems to be one of these options?
1. Prevent deleting UserProfile objects via the site admin UI
2. Enforce data integrity when deleting UserProfile objects via the site admin UI


[1] https://github.com/mozilla/kuma/tree/rev-dash-ise-hotfix

Comment 4

[Jannis Leidel [:jezdez]]

:groovecoder I haven't looked at what you did and would appreciate if you wouldn't do after-hour fixes and then delete the branch you tried it in. The rev-dash-ise-hotfix branch doesn't exist and I have no idea what you mean with the above statements.

So far this ticket lacks information about what happened, the recent amount of "ISE - something went wrong" tickets is concerning. I thought that's what we had the ticket triaging meeting?

Comment 5

[Luke Crouch [:groovecoder]]

Oh, sorry I deleted the wrong branch. Restored: https://github.com/mozilla/kuma/commits/rev-dash-ise-hotfix

Comment 6

[Rob Hudson [:robhudson]]

Can't reproduce this. Closing.