1178579 - the phone doesn't vibrate when I press a number in the Calculator app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Feedback, defect)

Description

[Irina Sandu]

User-Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

The phone should provide haptic feedback when I press a number in the Calculator app.

Comment 1

[Doug Sherk (:drs) (inactive)]

Triagr automatic comment: didn't know what to do when triaging.

Comment 2

[Tiffanie Shakespeare [:tif]]

Keyboard should consistently providing haptic feedback - it seems like Calculator is a one off.

NI Harly as FYI.

Thanks for pinging the UX team!

Comment 3

[Harly Hsu[:harly]]

Yes, I agree with both Irina and Tiff that we should probably add haptic feedback to calculator.

Comment 4

[Alexey Yakimov]

Attachment: Bug 1178579 - Adding haptic feedback for key press.patch

Fabrice, I've choosen you for review since you are the only suggested reviewer for this component. However, I'm not sure whether you are the right person for calculator related bugs, so please feel free to reassign it to more suitable person.

The patch is very simple, but the problem is that calculator is not a part of gaia repository and it is distributed as hosted app. The source code is stored in a separate repository, so I've also created a PR there: https://github.com/mozilla/calculator/pull/95

Comment 5

[[:fabrice] Fabrice Desré]

Comment on attachment 8692915 [details] [diff] [review]
Bug 1178579 - Adding haptic feedback for key press.patch

Review of attachment 8692915 [details] [diff] [review]:
-----------------------------------------------------------------

r=me 
Let me know if you need help to merge the PR.

Comment 6

[Alexey Yakimov]

Fabrice, thanks for the review! I would appreciate your help with merging this. I requested Nick Desaulniers to merge this PR to calculator repo (https://github.com/mozilla/calculator/pull/95), but I'm not sure how long it will take since last activity for this repo was more than a year ago. 

I'm also not sure whether I need to manually update application.zip in hosted_apps folder in gaia repo here https://github.com/mozilla-b2g/gaia/tree/master/hosted_apps/calculator or it is automatically taken from calculator repo by some script. So, if you have any idea how to handle it please advise the right way.

Comment 7

[[:fabrice] Fabrice Desré]

It looks like Nick is looking at your PR, so I'll let him merge.
https://github.com/mozilla-b2g/gaia/tree/master/hosted_apps/calculator will have to be updated once the calculator app is updated in the marketplace.

Comment 8

[(not reading bugmail) Nick Desaulniers [:\n]]

version 2.0.3 is in the review queue.  Thanks all!