1178696 - [Browser]There is a white area in address bar.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Lance（leave from Mozilla）]

Attachment: 2015-07-01-14-46-41.png

[1.Description]:
[Flame v2.2 & v3.0][Nexus 5 v2.2 & v3.0][Browser]When the address bar is minimized, a white area will be displayed.
Found time:14:46
See attachment:2015-07-01-14-46-41.png and logcat_1446.txt

[2.Testing Steps]: 
1.Launch Settings.
2.Tap "App Permissions".
3.Tap any apps -> "Author".

[3.Expected Result]: 
3.The white area should not appear.

[4.Actual Result]: 
3.After the address bar is minimized, a white area will be displayed.

[5.Reproduction build]: 
Device: Flame 2.2 version(Affected):
Build ID               20150629162503
Gaia Revision          b39d4f5b4937592ded19ec65e113a74177ae1f86
Gaia Date              2015-06-29 13:01:35
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/cefa70ef71e4
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150629.223916
Firmware Date          Mon Jun 29 22:39:27 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0 version(Affected):
Build ID               20150629134017
Gaia Revision          27fe0f4261e3685187769411f2f74cff19287b19
Gaia Date              2015-06-29 14:29:00
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/c26dbd63604d
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150629.170951
Firmware Date          Mon Jun 29 17:10:03 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5_2.2 version(Affected):
Build ID               20150629162503
Gaia Revision          b39d4f5b4937592ded19ec65e113a74177ae1f86
Gaia Date              2015-06-29 13:01:35
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/cefa70ef71e4
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150629.223845
Firmware Date          Mon Jun 29 22:39:02 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5_3.0 version(Affected):
Build ID               20150629134017
Gaia Revision          27fe0f4261e3685187769411f2f74cff19287b19
Gaia Date              2015-06-29 14:29:00
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/c26dbd63604d
Gecko Version          42.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150629.170843
Firmware Date          Mon Jun 29 17:09:00 EDT 2015
Bootloader             HHZ12f

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Lance（leave from Mozilla）]

Attachment: logcat_1446.txt

Comment 2

[Hermes Cheng (inactive after July 27, 2015)]

Gregor, do you know who can take a look?

Comment 3

[Gregor Wagner [:gwagner]]

Alberto, can you take a look?

Comment 4

[Alberto Pastor [:albertopq]]

Yeah, I think the main problem here is about the consistency of the rocketbar input width on all the apps. I'll take a look. Thanks!

Comment 5

[Alberto Pastor [:albertopq]]

Attachment: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30817

I noticed that right now, the rocketbar width is different in the browser vs rest of apps. My guess is that the browser needs to show the page title, so it's a little bit bigger. The rest of apps just show 'Search the web', so we give more space to the statusbar icons.

What I fixed in this patch:

- Now the rocketbar width is always the same in the collapsed browser (no matter if you have back/forward buttons when is expanded)

- I kept the rest of apps with a smaller rocketbar (as it is right now), but fixed the icons space, as we were not taking advantage of the new space created by the rocketbar

Eric, could you review this patch to see if these changes are following the spec?

Thanks!

Comment 6

[Eric Pang [:epang] UX]

Comment on attachment 8629311 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30817

Hey Alberto, in my spec the collapsed state is the same in apps and browser.  So it's strange it's been implemented as different widths.  Not a big deal though (you're reasoning makes sense).  The reason I'm marking as r- is because I'm still seeing the problem this bug was opened for.

Comment 7

[Alberto Pastor [:albertopq]]

Comment on attachment 8629311 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30817

Should be fine now. Thanks!

Comment 8

[Eric Pang [:epang] UX]

Comment on attachment 8629311 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30817

Looks good now R+
Sorry for the delay, I was on PTO. Thanks Alberto!

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8629311 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30817

This works well and the change makes sense, but I don't feel completely comfortable reviewing this code especially since we have the perfect reviewer in kgrandon :)

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 8629311 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30817

This unfortunately breaks fullscreen apps /w navigation. You can test this by downloading the guardian from the marketplace, or using this mock app: https://github.com/mozilla-b2g/gaia/tree/master/apps/system/test/apps/fullscreennavapp

It's pretty easy to debug if you install that mock app using something like webIDE. Once it's installed you can swipe down from the top to see the rocketbar. You'll see that the width is incorrect.

Comment 11

[Alberto Pastor [:albertopq]]

Hey Kevin, I installed the guardian app and the width seems fine to me (at least, I the same than in master). Is there any specific STR I need to follow? Thanks!

Comment 12

[Kevin Grandon :kgrandon]

(In reply to Alberto Pastor [:albertopq] from comment #11)
> Hey Kevin, I installed the guardian app and the width seems fine to me (at
> least, I the same than in master). Is there any specific STR I need to
> follow? Thanks!

Can you take a screenshot of what you see with the guardian app? When I swipe down to see the URLbar, it does not take the full width of the page as it should.

Comment 13

[Alberto Pastor [:albertopq]]

Attachment: theguardian.png

Comment 14

[Kevin Grandon :kgrandon]

Attachment: Screenshot of problem /w fullscreen nav

Ugh, unfortunately marketplace is giving me problems today, so I can't install the guardian, but here's what I'm seeing with the fullscreen nav app with your branch applied to latest master. (I was seeing this same problem with the guardian).

This screenshot comes from a flame, but it should also impact a z3, I can test on that device as well later.

Comment 15

[Alberto Pastor [:albertopq]]

Attachment: fullscreennavap.png

The test app works fine for me as well

Comment 16

[Alberto Pastor [:albertopq]]

Can someone in QA verify that, with this patch, fullscreen navigation is not broken? (see previous comments) I tested in both Z3 and Flame and both work for me. Thanks!

Comment 17

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: Flame screenshots demonstrating bugs after patch

QA test results:

- Before patch on Flame -
Original bug (comment 0) - Fail
The Guardian - Pass

- Before patch on Aries -
Original bug - Pass
The Guardian - Pass

- After patch on Flame - 
Original bug - Fail (still shows original bug)
The Guardian - Fail (status bar/URL bar color does not match the app; displays as white instead of blue)

- After patch on Aries -
Original bug - Fail (shows original bug when it wasn't there before patch)
The Guardian - Fail (status bar/URL bar color does not match the app; displays as white instead of blue)

See attached screenshots taken from Flame AFTER patch.

Tested on:
Device: Flame
BuildID: 20150721010202
Gecko: 3a4bfa5d2d02
Version: 42.0a1 (2.5 Master) 
Firmware Version: v18D nightly v4
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Device: Aries
BuildID: 20150721153949
Gecko: 512c7e8f0030
Version: 42.0a1 (2.5 Master) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Comment 18

[Alberto Pastor [:albertopq]]

I think definitely something went wrong during these tests. The fact that without the patch, you weren't reproing on Aries, and then differences between Flame and Aries...

I rebased the patch. Could you please try again:

Original Issue STR:

1.- Go to Settings -> App permissions, and click on the Calculator author link (the app is important)
2.- Check that search input is uniform (no white area), and the size is correct when maximizing/minimizing and the buttons are visible (back, forward...)

Issue that Kevin was mentioning:

1.- Install the Guardian app
2.- Pull down the statusbar and make sure the width is 100%. See https://bug1178696.bmoattachments.org/attachment.cgi?id=8635031 (if there is a color issue, is a different bug)

Thanks!

Comment 19

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: Screenshot of Flame after patch (see refresh button overlaps with ellipsis)

I don't know what's causing those discrepancies. It could have been a bad flash on Aries. I'm pretty sure I got the STRs correct, otherwise the screenshots would have seemed irrelevant. I used Find My Device author link because that's what's consistent with both Flame and Aries (Flame doesn't have Calculator app).

Today I'm seeing the different color status/URL bar issue before patch on The Guardian, so I think it's unrelated.

Re-tested everything:

- Before patch on Flame -
Original bug (comment 0) - Fail
The Guardian - Pass

- Before patch on Aries -
Original bug - Fail
The Guardian - Pass

- After patch on Flame - 
Original bug - Fail (overlap on refresh button, see attached screenshot)
The Guardian - Pass

- After patch on Aries -
Original bug - Pass
The Guardian - Pass

STR on the failed Flame result:
1) Settings > App Permissions > Find My Device > tap on the link
2) Tap on 'https//wiki.mozilla.org/B2G' link > tap on 'Release details' link > scroll down and tap on 'Last modified 3 days ago' link > tap on 'View logs for this page' link > tap the Back arrow button on browser (bug occurs; exclusive to Flame device, does not occur on Aries)

Comment 20

[Alberto Pastor [:albertopq]]

Thanks for the info! So it seems that the patch fixes the original problem (the only failure after the patch is the refresh button in the flame). I'll take a look to that and flag you again to double check.

Thanks!

Comment 21

[Alberto Pastor [:albertopq]]

Ok, now everything should be fine. Could you please take a last look?
Thanks!

Comment 22

[Pi Wei Cheng [:piwei] (inactive)]

QAwanted to test the new patch.

Comment 23

[Pi Wei Cheng [:piwei] (inactive)]

Tested with today's nightly:

- Before patch on Flame -
Original bug (comment 0) - Fail
The Guardian - Pass

- Before patch on Aries -
Original bug - Fail
The Guardian - Pass

- After patch on Flame - 
Original bug - Pass
The Guardian - Pass

- After patch on Aries -
Original bug - Pass
The Guardian - Pass

Everything looks good to me.

Comment 24

[Alberto Pastor [:albertopq]]

Comment on attachment 8629311 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30817

Hey Kevin, could you please take another look? Thanks!

Comment 25

[Kevin Grandon :kgrandon]

Comment on attachment 8629311 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30817

Seems to work well for me, thanks!

Comment 26

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/e3e4cba7d400a0913bc247b0fd51a47dc9e4c5f3

Comment 27

[Lance（leave from Mozilla）]

Attachment: Aries_2.5_guardian.png

According to the STR of Comment 18, this bug has been verified as pass on latest Nightly Flame KK 2.5, Nexus_5 L 2.5 and Aries KK 2.5.

Actual results: 
Original bug - The white area doesn't display.(Pass)
The Guardian - The statusbar's width is 100%.(Pass)

See attachment:Aries_2.5_original.png and Aries_2.5_guardian.png
Fail rate:0/5

Device: Aries KK 2.5(Pass)
Build ID               20150803195455
Gaia Revision          dbacf8364f4505d021b7d8fb9cabea325004dbcc
Gaia Date              2015-08-03 16:38:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/abc56d57f6e1
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150803.191800
Firmware Date          Mon Aug  3 19:18:08 UTC 2015
Bootloader             s1

Device: Flame KK 2.5(Pass)
Build ID               20150804150207
Gaia Revision          c5425d9f1f5184731a59ed4bc99295acbde30390
Gaia Date              2015-08-04 16:09:19
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f3b757156f69
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150804.184538
Firmware Date          Tue Aug  4 18:45:50 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Nexus_5 L 2.5(Pass)
Build ID               20150804150207
Gaia Revision          c5425d9f1f5184731a59ed4bc99295acbde30390
Gaia Date              2015-08-04 16:09:19
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f3b757156f69
Gecko Version          42.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150804.184149
Firmware Date          Tue Aug  4 18:42:07 EDT 2015
Bootloader             HHZ12f

Comment 28

[Lance（leave from Mozilla）]

Attachment: Aries_2.5_original.png