1178725 - [tv-epg] check and enable tv_epg_test.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

+++ This bug was initially created as a clone of Bug #1178689 +++

TEST-UNEXPECTED-FAIL | tv_apps/tv-epg/test/marionette/tv_epg_test.js | Test Program Navigation "before each" hook

see https://s3-us-west-2.amazonaws.com/taskcluster-public-artifacts/CK_XPVxLQ-aNc9K2lfdtdw/4/public/logs/live_backing.log

==============

This issue can be reproduced at local. Once [1] are commented, the test pass and app doesn't crash while opening it at b2g desktop.

[1] https://github.com/mozilla-b2g/gaia/blob/15824036f5ce2d0ba62fada6e226b07649dff007/tv_apps/tv-epg/js/context_menu.js#L13-L25

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

This seems to be a gecko issue about IAC.

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

I found the tv-deck also crashed at this case. It may be a chained effect. We use IAC to connect to tv-deck from tv-epg. And tv-deck crashed at this case which makes b2g-desktop crashed.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

If we comment [1], the whole test cases and scenario pass. My assumption at comment 2 is correct. The root issue is related to mediastream[1].

[1] https://github.com/mozilla-b2g/gaia/blob/fe01a479af3ff57ea5e0b07dad1cb1143edda4ca/tv_apps/tv-deck/js/tv_deck.js#L164-L169

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

According to the log [1], it seems we got this issue at June 19th, 2015.

[1] https://treeherder.mozilla.org/#/jobs?repo=gaia

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

I use different version of b2g-desktop with latest master to test and find:

0. 2015-06-17-01-02-05-mozilla-central [0]: passed
1. 2015-06-18-16-02-06-mozilla-central [1]: failed


[0] https://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/2015-06-17-01-02-05-mozilla-central/
[1] https://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/2015-06-18-16-02-06-mozilla-central/

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

(In reply to John Hu [:johnhu][:johu][:醬糊小弟] from comment #5)
> I use different version of b2g-desktop with latest master to test and find:
> 
> 0. 2015-06-17-01-02-05-mozilla-central [0]: passed
> 1. 2015-06-18-16-02-06-mozilla-central [1]: failed
> 

Sorry, I use the latest gaia master to test.

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

Sean,

The mediastream we got at[1] is a LocalMediaStream instance which is got from navigator.tv.getTuners(). While setting it to video element, it crashed. Would you mind to check it. I think this is a regression at 2015-06-18, see comment 5 and 6.

[1] https://github.com/mozilla-b2g/gaia/blob/fe01a479af3ff57ea5e0b07dad1cb1143edda4ca/tv_apps/tv-deck/js/tv_deck.js#L164

Comment 8

[Sean Lin [:seanlin] (inactive from Mar 2016)]

Hi Daosheng,

You've done some work to generate the tuner media stream and may know more details about it. Could you help look into this issue and share what you find?

Comment 9

[Daosheng Mu[:daoshengmu]]

Attachment: 0001-Bug-1178725-Fix-create-videoFrameContainer-crash-on-.patch

Fix the crash of DomHwMediastream on B2G desktop build. Please help me try this patch.

Comment 10

[John Hu [:johnhu][:johu][:醬糊小弟]]

I had tested this patch in my site. It looks good.

Comment 11

[John Hu [:johnhu][:johu][:醬糊小弟]]

I will file another bug to enable our test once this patch is landed.

Comment 12

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8641696 [details] [diff] [review]
0001-Bug-1178725-Fix-create-videoFrameContainer-crash-on-.patch

Review of attachment 8641696 [details] [diff] [review]:
-----------------------------------------------------------------

roc, please help me review this bug.

Comment 13

[John Hu [:johnhu][:johu][:醬糊小弟]]

Integration tests passed while we run tests with this patch.

Comment 14

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1178725 - Fix create videoFrameContainer crash on B2G desktop. r=roc

On B2G desktop, disable using OverlayImage

V2:
  - add r=roc on commit message.

Comment 15

[Daosheng Mu[:daoshengmu]]

Try link: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5f07b4ea452

Please land attachment 8644102 [details] [diff] [review] to m-c.

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/e377cd3e0784

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e377cd3e0784