Closed Bug 1178739 Opened 5 years ago Closed 5 days ago
Provider eslint errors
This change introduced the regression (bug 1177774): https://hg.mozilla.org/mozilla-central/rev/8cab4b5abe7f Michael: The change should have fixed an eslint issue and I'm not sure how this can trigger the error mentioned above. Do you have any idea?
Let's just back out this changeset. Mike and I weren't confident when we made this change, and obviously we missed something!
I did the backout in bug 1177774. Let's morph this bug to be about fixing the HomeProvider linter errors without breaking things :)
We should talk to someone who actually knows about how these jsm contexts work (khuey or fabrice would likely know) to understand what went wrong here. I also think we should audit the other jsms in /mobile/android/modules, because I suspect we may be doing things wrong in other places, but not running into errors because we're not using sqlite in any of those.
(In reply to :Margaret Leibovic from comment #4) > I also think we should audit the other jsms in /mobile/android/modules, > because I suspect we may be doing things wrong in other places, but not > running into errors because we're not using sqlite in any of those. NI self to audit my linter changes.
tracking-fennec: ? → -
I'll get to this eventually – don't need the NI as it's already on my mind.
Duplicate of this bug: 1229434
Depends on: 1229433
I ignored this file in bug 1229433 to make `mach eslint mobile` pass.
Mark mentioned this might have something to do with bug 1185578.
Bug 1378788 is going to enable eslint for HomeProvider.jsm - it is clean now from an ESLint perspective.
Depends on: 1378788
Status: NEW → RESOLVED
Closed: 5 days ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.