1178742 - [regression] mainthreadio tests are failing silently

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Julien Pagès (:parkouss)]

:bobowen just found that I introduced a regression with that cleanup patch:

http://hg.mozilla.org/build/talos/rev/0600cd6a8eba

See

http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32-pgo/1435631410/mozilla-central_win7-ix_test-xperf-e10s-pgo-bm112-tests1-windows-build112.txt.gz

and search for STAGE_STRING in there.

there is an index error because I reduced this string list with:

http://hg.mozilla.org/build/talos/diff/0600cd6a8eba/talos/mainthreadio.py

I thought it was clever, because the constants were not used; wrong.

Thanks :bobowen for the usefull bug report. :)

Comment 1

[Julien Pagès (:parkouss)]

Attachment: 1178742.patch

Hey Will, as jmaher is on PTO, could you review that please ? I can land this on talos after - but maybe we should also update the talos revision used by try builds after that;

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8627656 [details] [diff] [review]
1178742.patch

Thanks Julien! Yes, we'll want to update talos.json to the new revision after this lands.

https://hg.mozilla.org/mozilla-central/file/291614a686f1/testing/talos/talos.json

Please attach a followup patch for m-c after this one to get that landed.

Comment 3

[Julien Pagès (:parkouss)]

Cool! Will do that in something like one hour - can't push from here.

Comment 4

[Julien Pagès (:parkouss)]

Landed:

https://hg.mozilla.org/build/talos/rev/554aa164ba0b

Comment 5

[Julien Pagès (:parkouss)]

Attachment: bug1178742.patch

update talos.json

Comment 6

[Julien Pagès (:parkouss)]

Pushed to try, just to be safe:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a884f21f43cc

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/82099594ef80

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/82099594ef80