Closed Bug 1178804 Opened 9 years ago Closed 9 years ago

Implement new fxaccount_sync_error.png assets

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox42 fixed)

RESOLVED FIXED
Firefox 42
Tracking Status
firefox42 --- fixed

People

(Reporter: mhaigh, Assigned: mhaigh)

References

Details

Attachments

(3 files)

In bug 1171946 comment 4 I discovered that the fxaccount_sync_error.png asset (attached) was only defined in mdpi.  That bug removes mdpi assets from Fx so we really need new assets in hdpi, xhdi and xxhdpi to replace this one.

Currently the mdpi asset is living in hdpi, so this needs fixing quickly!
antlam - can you provide assets?
Flags: needinfo?(alam)
This doesn't need to be pixel perfect, folks -- an SVG, or even just a red circle, could do for now.  (I'm quite certain I punked this from the web somewhere.)
I can't figure out where this icon is coming from so I re-made it based on the assets dimensions and style.. and exported out all the other assets we need.

Give these a try!
Flags: needinfo?(alam) → needinfo?(mhaigh)
Depends on: 1177920
Bug 1178804 is breaking sync, so even though this is a low risk patch, we can't test until the patch for 1178804 lands.
Flags: needinfo?(mhaigh)
mhaigh: no need to block on that ticket; this is super low risk.  Either just land or push a patch and NI vivek to test.
Bug 1178804 - Implement new fxaccount_sync_error.png assets; r?nalexander
Attachment #8629342 - Flags: review?(nalexander)
url:        https://hg.mozilla.org/integration/fx-team/rev/46cc76d084ba0466d9a2f0b8b20f1e2c24ab2465
changeset:  46cc76d084ba0466d9a2f0b8b20f1e2c24ab2465
user:       Martyn Haigh <mhaigh@mozilla.org>
date:       Fri Jul 03 13:18:01 2015 +0100
description:
Bug 1178804 - Implement new fxaccount_sync_error.png assets; r=nalexander
Comment on attachment 8629342 [details]
MozReview Request: Bug 1178804 - Implement new fxaccount_sync_error.png assets; r?nalexander

Landed.
Attachment #8629342 - Flags: review?(nalexander) → review+
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/46cc76d084ba
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: