1178804 - Implement new fxaccount_sync_error.png assets

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martyn Haigh (:mhaigh)]

Attachment: fxaccount_sync_error.png

In bug 1171946 comment 4 I discovered that the fxaccount_sync_error.png asset (attached) was only defined in mdpi.  That bug removes mdpi assets from Fx so we really need new assets in hdpi, xhdi and xxhdpi to replace this one.

Currently the mdpi asset is living in hdpi, so this needs fixing quickly!

Comment 1

[Martyn Haigh (:mhaigh)]

antlam - can you provide assets?

Comment 2

[Nick Alexander :nalexander [he/him]]

This doesn't need to be pixel perfect, folks -- an SVG, or even just a red circle, could do for now.  (I'm quite certain I punked this from the web somewhere.)

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: FxA_syncerror_icons.zip

I can't figure out where this icon is coming from so I re-made it based on the assets dimensions and style.. and exported out all the other assets we need.

Give these a try!

Comment 4

[Martyn Haigh (:mhaigh)]

Bug 1178804 is breaking sync, so even though this is a low risk patch, we can't test until the patch for 1178804 lands.

Comment 5

[Nick Alexander :nalexander [he/him]]

mhaigh: no need to block on that ticket; this is super low risk.  Either just land or push a patch and NI vivek to test.

Comment 6

[Martyn Haigh (:mhaigh)]

Attachment: MozReview Request: Bug 1178804 - Implement new fxaccount_sync_error.png assets; r?nalexander

Bug 1178804 - Implement new fxaccount_sync_error.png assets; r?nalexander

Comment 7

[Nick Alexander :nalexander [he/him]]

url:        https://hg.mozilla.org/integration/fx-team/rev/46cc76d084ba0466d9a2f0b8b20f1e2c24ab2465
changeset:  46cc76d084ba0466d9a2f0b8b20f1e2c24ab2465
user:       Martyn Haigh <[e-mail]>
date:       Fri Jul 03 13:18:01 2015 +0100
description:
Bug 1178804 - Implement new fxaccount_sync_error.png assets; r=nalexander

Comment 8

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8629342 [details]
MozReview Request: Bug 1178804 - Implement new fxaccount_sync_error.png assets; r?nalexander

Landed.

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/46cc76d084ba