1178806 - IDB autoincrement overflow should throw a ConstraintError, not UnknownError

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: IndexedDB autoincrement overflow should be throwing ConstraintError per spec

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8627738 [details] [diff] [review]
IndexedDB autoincrement overflow should be throwing ConstraintError per spec

Review of attachment 8627738 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome thanks.

::: dom/indexedDB/ActorsParent.cpp
@@ +23266,5 @@
>  
>        MOZ_ASSERT(autoIncrementNum > 0);
>  
>        if (autoIncrementNum > (1LL << 53)) {
>          IDB_REPORT_INTERNAL_ERR();

Can you remove this line also?

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f87683a37d20

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f87683a37d20