Last Comment Bug 1178811 - Error message concerning expired Bugzilla session is misleading
: Error message concerning expired Bugzilla session is misleading
Status: RESOLVED FIXED
:
Product: MozReview
Classification: Other
Component: General (show other bugs)
: unspecified
: Unspecified Unspecified
P1 normal
: ---
Assigned To: Mark Côté [:mcote]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-06-30 09:34 PDT by Mark Côté [:mcote]
Modified: 2016-02-21 20:31 PST (History)
1 user (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

MozReview Requests
Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:
Show discarded requests

Attachments
MozReview Request: mozreview: Use a more comprehensible error message when the Bugzilla cookie has expired (bug 1178811). r?smacleod (40 bytes, text/x-review-board-request)
2015-07-06 10:39 PDT, Mark Côté [:mcote]
smacleod: review+
Details | Review

Description User image Mark Côté [:mcote] 2015-06-30 09:34:38 PDT
If you try to perform a Bugzilla-related action from within MozReview (search for users, publish a review/review request, etc.) and the Bugzilla login cookie that MozReview stores on your behalf has expired, you will get the following error:

Bugzilla error: The cookies or token provide were not valid or have expired. You may login again to get new cookies or a new token.

This comes straight from Bugzilla.  It is rather confusing because the implication is that you should log out and back into Bugzilla, whereas the real fix is to log out of and back into Review Board (causing a fresh cookie to be stored).

We should catch these particular error messages and rewrite them into something more comprehensible before passing them up to the UI.

Note that this problem will change but may still be relevant after the switch to Bugzilla API keys, since Bugzilla will return an error if the user has revoked their key.  The fix will be the same, but we'll have to look for the new message/code.
Comment 1 User image Mark Côté [:mcote] 2015-07-06 10:39:20 PDT
Created attachment 8630052 [details]
MozReview Request: mozreview: Use a more comprehensible error message when the Bugzilla cookie has expired (bug 1178811). r?smacleod

mozreview: Use a more comprehensible error message when the Bugzilla cookie has expired (bug 1178811). r?smacleod
Comment 2 User image Steven MacLeod [:smacleod] 2015-07-06 15:09:19 PDT
Comment on attachment 8630052 [details]
MozReview Request: mozreview: Use a more comprehensible error message when the Bugzilla cookie has expired (bug 1178811). r?smacleod

https://reviewboard.mozilla.org/r/12671/#review11225

::: pylib/rbbz/rbbz/bugzilla.py:23
(Diff revision 1)
> +                # is a little confusing in the context of MozReview.  Override

:O... please don't tell me you're a 2 spaces after period person? 1 space please... 1 space :)
Comment 3 User image Mark Côté [:mcote] 2015-07-07 07:22:26 PDT
https://reviewboard.mozilla.org/r/12671/#review11225

> :O... please don't tell me you're a 2 spaces after period person? 1 space please... 1 space :)

For monospace fonts, I am.  But I'm not married to it. :)

Note You need to log in before you can comment on or make changes to this bug.