1178877 - queue: Implement task.priority

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Jonas Finnemann Jensen (:jonasfj)]

Add support for priority, at this point I suggest we add the following priorities:
 - normal
 - high    (requires scope: "queue:task-priority:high")

well, something like that.

We can always add more priority levels, but we shouldn't add them unless we
really need them.

Comment 1

[Jonas Finnemann Jensen (:jonasfj)]

Attachment: Github PR

@garndt, Your worker will be polling from this... It should work -- it's not really different from when we had legacy queue names.
Anyways, give it a quick review, and feel free to ask questions :)

@jhford, you're the only one who has actually used base.Entity migration in
production. Is there anything I should watch out for, or would you think
this works?

Note:
This patch uses entity migration, but we don't actually test that the migration
works. I'm not sure it necessary considering how simple the code is.
(And migration is tested at base.Entity level, I think!)

Comment 2

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 8636806 [details] [review]
Github PR

(In reply to Jonas Finnemann Jensen (:jonasfj) from comment #1)
> Created attachment 8636806 [details] [review]
> Github PR
> 
> @jhford, you're the only one who has actually used base.Entity migration in
> production. Is there anything I should watch out for, or would you think
> this works?

You mentioned to me that I should be returning a new object from the migration function instead of modifying the one that's passed in... I think you said that either works.  In this case, the modification is so simple it's probably fine.

> Note:
> This patch uses entity migration, but we don't actually test that the
> migration
> works. I'm not sure it necessary considering how simple the code is.
> (And migration is tested at base.Entity level, I think!)

It looks like it should work given my experience with migration.  I found the experience to be mostly nice, except for when I made a camelcasing typo and had to add a silly cleanup thing in the http api :)

Comment 3

[Jonas Finnemann Jensen (:jonasfj)]

Deployed to production and tasks can still be submitted... I hope the world isn't coming to an end...