1178892 - Split the profiler into Core & Gecko files and break apart monolithic headers

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Benoit Girard (:BenWa)]

Just a first round of profiler clean-up. I'll do more here and there as I find the time.

Comment 1

[Benoit Girard (:BenWa)]

Attachment: MozReview Request: Bug 1178892 - Split the profiler into Core & Gecko files and break apart monolithic headers. r=mstange

Bug 1178892 - Split the profiler into Core & Gecko files and break apart monolithic headers. r?mstange

Comment 2

[Benoit Girard (:BenWa)]

Pushing and poping this file seems like it requires a CLOBBER:
 2:05.02 make[5]: *** No rule to make target `/Users/bgirard/mozilla/mozilla-central/tree/tools/profiler/gecko/local_debug_info_symbolizer.cc', needed by `local_debug_info_symbolizer.o'.  Stop.

I got this error when poping the patch. Got a similar one when I pushed it.

Comment 3

[Markus Stange [:mstange]]

Note that bug 1173847 will remove a few of the files that you're moving.

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 8627825 [details]
MozReview Request: Bug 1178892 - Split the profiler into Core & Gecko files and break apart monolithic headers. r=mstange

https://reviewboard.mozilla.org/r/12289/#review10777

Ship It!

::: tools/profiler/moz.build:30
(Diff revision 1)
> -        'nsProfiler.cpp',
> -        'nsProfilerFactory.cpp',
> -        'nsProfilerStartParams.cpp',
> -        'platform.cpp',
> -        'ProfileEntry.cpp',
> -        'ProfileGatherer.cpp',
> -        'ProfileJSONWriter.cpp',
> -        'ProfilerBacktrace.cpp',
> -        'ProfilerIOInterposeObserver.cpp',
> -        'ProfilerMarkers.cpp',
> -        'SaveProfileTask.cpp',
> -        'SyncProfile.cpp',
> -        'TableTicker.cpp',
> -        'ThreadResponsiveness.cpp',
> +        'core/GeckoSampler.cpp',
> +        'core/platform.cpp',
> +        'core/ProfileBuffer.cpp',
> +        'core/ProfileEntry.cpp',
> +        'core/ProfileJSONWriter.cpp',
> +        'core/ProfilerBacktrace.cpp',
> +        'core/ProfilerMarkers.cpp',
> +        'core/SyncProfile.cpp',
> +        'core/ThreadInfo.cpp',
> +        'core/ThreadProfile.cpp',
> +        'gecko/nsProfiler.cpp',
> +        'gecko/nsProfilerFactory.cpp',
> +        'gecko/nsProfilerStartParams.cpp',
> +        'gecko/ProfileGatherer.cpp',
> +        'gecko/ProfilerIOInterposeObserver.cpp',
> +        'gecko/SaveProfileTask.cpp',
> +        'gecko/ThreadResponsiveness.cpp',

I don't know how common it is to refer to files in subdirectories from the moz.build vs adding new moz.build files to those subdirectories. Better get a build peer to review this.

The rest looks good!

Comment 5

[Benoit Girard (:BenWa)]

Comment on attachment 8627825 [details]
MozReview Request: Bug 1178892 - Split the profiler into Core & Gecko files and break apart monolithic headers. r=mstange

Can you review the moz.build changes?

I modeled this after the gfx/layers build. We're using sub folders here to indicate that the files belong to different logical pieces of the profiler but we don't really want intermediate libraries or different build settings for them.

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8627825 [details]
MozReview Request: Bug 1178892 - Split the profiler into Core & Gecko files and break apart monolithic headers. r=mstange

https://reviewboard.mozilla.org/r/12289/#review10807

The moz.build foo looks good.

Comment 7

[Benoit Girard (:BenWa)]

Comment on attachment 8627825 [details]
MozReview Request: Bug 1178892 - Split the profiler into Core & Gecko files and break apart monolithic headers. r=mstange

Bug 1178892 - Split the profiler into Core & Gecko files and break apart monolithic headers. r=mstange

Comment 8

[Markus Stange [:mstange]]

Comment on attachment 8627825 [details]
MozReview Request: Bug 1178892 - Split the profiler into Core & Gecko files and break apart monolithic headers. r=mstange

https://reviewboard.mozilla.org/r/12289/#review10975

Ship It!

Comment 9

[Benoit Girard (:BenWa)]

Comment on attachment 8627825 [details]
MozReview Request: Bug 1178892 - Split the profiler into Core & Gecko files and break apart monolithic headers. r=mstange

Bug 1178892 - Split the profiler into Core & Gecko files and break apart monolithic headers. r=mstange

Comment 10

[Benoit Girard (:BenWa)]

Comment on attachment 8627825 [details]
MozReview Request: Bug 1178892 - Split the profiler into Core & Gecko files and break apart monolithic headers. r=mstange

Bug 1178892 - Split the profiler into Core & Gecko files and break apart monolithic headers. r=mstange

Comment 11

[Benoit Girard (:BenWa)]

Comment on attachment 8627825 [details]
MozReview Request: Bug 1178892 - Split the profiler into Core & Gecko files and break apart monolithic headers. r=mstange

Bug 1178892 - Split the profiler into Core & Gecko files and break apart monolithic headers. r=mstange

Comment 12

[Benoit Girard (:BenWa)]

The above was to resolve the conflict with bug bug 1173847.

Comment 13

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/94714c206f18

Comment 14

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/94714c206f18