1178945 - Add 'tsz' and 'cak' locales to the Fennec build

Status: VERIFIED FIXED

(Release Engineering :: General, defect)

Description

[Jeff Beatty [:gueroJeff]]

We need to add 'tsz' to the Fenenc Aurora l10n builds.

PS: to be clear to the localization team, this bug is handled by Mozilla staff.

Comment 1

[Rail Aliiev [:rail]]

Attachment: tsz.diff

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 8627852 [details] [diff] [review]
tsz.diff

lgtm, r=me.

We'll want to wait for the actual repos to not run into odd situations.

Comment 4

[Rail Aliiev [:rail]]

Attachment: cak+tsz.diff

Combined with bug 1178930 now

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 8628067 [details] [diff] [review]
cak+tsz.diff

Review of attachment 8628067 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks.

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 8628067 [details] [diff] [review]
cak+tsz.diff

This is an aurora-only patch, enabling 2 Android locales.
[Risks and why]: It affects Android l10n repacks only.

Comment 7

[Rail Aliiev [:rail]]

The repos look ready, just waiting for a+.

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8628067 [details] [diff] [review]
cak+tsz.diff

Approving the uplift to moz-aurora. Patch looks simple and blessed by Axel.

Comment 10

[Jeff Beatty [:gueroJeff]]

Awesome! Thank you ritu and rail.

Added to the whiteboard to be sure the patch gets checked in this afternoon.

Comment 11

[Rail Aliiev [:rail]]

Comment on attachment 8628067 [details] [diff] [review]
cak+tsz.diff

https://hg.mozilla.org/releases/mozilla-aurora/rev/432e6a592cf9

Comment 12

[Jeff Beatty [:gueroJeff]]

I found a tsz build this morning (which is beautiful!), but no cak build. Could you look into the build logs to see why cak was skipped/aborted?

Thanks!

Comment 13

[Axel Hecht [:Pike]]

See the two errors reported on the dashboard, https://l10n.mozilla.org/teams/cak, unescaped (\!) quotes in sync_strings.dtd:

Quotes in Android DTDs need escaping with \" or \u0022, or put string in apostrophes. at line 20, column 64 for sync.subtitle.pair.label
Quotes in Android DTDs need escaping with \" or \u0022, or put string in apostrophes. at line 20, column 85 for sync.subtitle.pair.label

Comment 14

[Jeff Beatty [:gueroJeff]]

I just went in and fixed those.

Would those be critical enough for a build to fail?

Comment 15

[Axel Hecht [:Pike]]

Princess Android being Princess, sadly. The apkbuilder dies for this.

FYI, https://treeherder.mozilla.org/#/jobs?repo=mozilla-aurora&exclusion_profile=false&filter-searchStr=night shows the builds.

Comment 16

[Jeff Beatty [:gueroJeff]]

Both builds are now available. Thank you all