1178955 - ./mach mercurial-setup fails if comment in the config starts with ';'

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Julien Pagès (:parkouss)]

> ./mach mercurial-setup
> Error importing existing Mercurial config!
> 
> Invalid line at line "10".
> Invalid line at line "12".

This is because I have comments starting with ';' at those line in my user config mercurial conf file. Using '#' instead fixes the bug.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1178955 - Don't pass config paths to updater; r?smacleod

Bug 1178955 - Don't pass config paths to updater; r?smacleod

They aren't needed.

Comment 2

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1178955 - Refactor config path selection; r?smacleod

Bug 1178955 - Refactor config path selection; r?smacleod

An upcoming commit will display the path of the config file in the error
message. In order to do this, the calling scope needs to know the path
to the config file.

Comment 3

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1178955 - Print config path on failure; r?smacleod

Bug 1178955 - Print config path on failure; r?smacleod

Actionable error messages are useful.

Comment 4

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1178955 - Error when semicolon comments are seen; r?smacleod

Bug 1178955 - Error when semicolon comments are seen; r?smacleod

configobj doesn't support semicolon comments. Why, I don't know, since
they are pretty common in ini files.

Do a static check for semicolon comments and print a more actionable
error message.

Comment 5

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1178955 - Print line number for parse errors; r?smacleod

Bug 1178955 - Print line number for parse errors; r?smacleod

Help users debug problems

Comment 6

[Steven MacLeod [:smacleod]]

Comment on attachment 8635381 [details]
MozReview Request: Bug 1178955 - Don't pass config paths to updater; r?smacleod

https://reviewboard.mozilla.org/r/13537/#review12161

Ship It!

Comment 7

[Steven MacLeod [:smacleod]]

Comment on attachment 8635382 [details]
MozReview Request: Bug 1178955 - Refactor config path selection; r?smacleod

https://reviewboard.mozilla.org/r/13539/#review12163

Ship It!

Comment 8

[Steven MacLeod [:smacleod]]

Comment on attachment 8635383 [details]
MozReview Request: Bug 1178955 - Print config path on failure; r?smacleod

https://reviewboard.mozilla.org/r/13541/#review12165

Ship It!

Comment 9

[Steven MacLeod [:smacleod]]

Comment on attachment 8635384 [details]
MozReview Request: Bug 1178955 - Error when semicolon comments are seen; r?smacleod

https://reviewboard.mozilla.org/r/13543/#review12167

Ship It!

Comment 10

[Steven MacLeod [:smacleod]]

Comment on attachment 8635385 [details]
MozReview Request: Bug 1178955 - Print line number for parse errors; r?smacleod

https://reviewboard.mozilla.org/r/13545/#review12169

Ship It!

Comment 11

[Gregory Szorc [:gps]]

url:        https://hg.mozilla.org/integration/fx-team/rev/a0fe4554cf59a20cf26715b7a0d11e8619c05b51
changeset:  a0fe4554cf59a20cf26715b7a0d11e8619c05b51
user:       Gregory Szorc <[e-mail]>
date:       Fri Jul 17 10:28:12 2015 -0700
description:
Bug 1178955 - Don't pass config paths to updater; r=smacleod

They aren't needed.

url:        https://hg.mozilla.org/integration/fx-team/rev/58c918dfc1d4f3c1abca25cd6d69420f94c28b60
changeset:  58c918dfc1d4f3c1abca25cd6d69420f94c28b60
user:       Gregory Szorc <[e-mail]>
date:       Fri Jul 17 10:28:29 2015 -0700
description:
Bug 1178955 - Refactor config path selection; r=smacleod

An upcoming commit will display the path of the config file in the error
message. In order to do this, the calling scope needs to know the path
to the config file.

url:        https://hg.mozilla.org/integration/fx-team/rev/7ba4776134607a33876f4d585ed4fa1a160655b2
changeset:  7ba4776134607a33876f4d585ed4fa1a160655b2
user:       Gregory Szorc <[e-mail]>
date:       Fri Jul 17 10:28:55 2015 -0700
description:
Bug 1178955 - Print config path on failure; r=smacleod

Actionable error messages are useful.

url:        https://hg.mozilla.org/integration/fx-team/rev/4bb683c801a32df52fb023df579c5cbf48293c35
changeset:  4bb683c801a32df52fb023df579c5cbf48293c35
user:       Gregory Szorc <[e-mail]>
date:       Fri Jul 17 10:29:09 2015 -0700
description:
Bug 1178955 - Error when semicolon comments are seen; r=smacleod

configobj doesn't support semicolon comments. Why, I don't know, since
they are pretty common in ini files.

Do a static check for semicolon comments and print a more actionable
error message.

url:        https://hg.mozilla.org/integration/fx-team/rev/07e78b13095d16859749da8911be57a5dd71ba42
changeset:  07e78b13095d16859749da8911be57a5dd71ba42
user:       Gregory Szorc <[e-mail]>
date:       Fri Jul 17 10:29:22 2015 -0700
description:
Bug 1178955 - Print line number for parse errors; r=smacleod

It helps users debug problems.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a0fe4554cf59
https://hg.mozilla.org/mozilla-central/rev/58c918dfc1d4
https://hg.mozilla.org/mozilla-central/rev/7ba477613460
https://hg.mozilla.org/mozilla-central/rev/4bb683c801a3
https://hg.mozilla.org/mozilla-central/rev/07e78b13095d