Measure editor usage in WebIDE

RESOLVED FIXED in Firefox 42

Status

defect
RESOLVED FIXED
4 years ago
11 months ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

unspecified
Firefox 43
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox42 fixed, firefox43 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

4 years ago
Track whether the project editor is used in WebIDE.
Assignee

Updated

4 years ago
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Assignee

Comment 1

4 years ago
Currently I am measuring:

* Displaying the project editing (existing project, new, etc.)
* Saving a file
* Creating a new project
* Importing an existing project

Happy to hear any feedback on additional metrics to measure.
Assignee

Comment 2

4 years ago
Posted patch webide-telem (obsolete) — Splinter Review
Attachment #8649017 - Flags: review?(poirot.alex)
Assignee

Comment 3

4 years ago
Axel, we've talked about this in the past a bit.  Any additional editing metrics we should gather?

Alex, you may also have additional ideas.
Flags: needinfo?(akratel)
Comment on attachment 8649017 [details] [diff] [review]
webide-telem

Review of attachment 8649017 [details] [diff] [review]:
-----------------------------------------------------------------

We could add many more probes, but I think that's enough for the project editor.
`webideProjectEditor` was really the most missing one!

::: browser/devtools/webide/content/webide.js
@@ +685,3 @@
>        } else {
>          this.projecteditor.menuEnabled = false;
> +        this._telemetry.toolClosed("webideProjectEditor");

I think we are going to call toolClosed multiple times if we switch between multiple non-project-editor decks.
Not a big deal if toolClosed handle this nicely.
Attachment #8649017 - Flags: review?(poirot.alex) → review+
Assignee

Comment 6

4 years ago
(In reply to Alexandre Poirot [:ochameau] from comment #4)
> ::: browser/devtools/webide/content/webide.js
> @@ +685,3 @@
> >        } else {
> >          this.projecteditor.menuEnabled = false;
> > +        this._telemetry.toolClosed("webideProjectEditor");
> 
> I think we are going to call toolClosed multiple times if we switch between
> multiple non-project-editor decks.
> Not a big deal if toolClosed handle this nicely.

Ah, I suppose you're right.  I'll remove my comment about only calling the function on a change.

Anyway, `toolClosed` does handle multiple calls in a row fine: it just stops a timer, if one was already running.
https://hg.mozilla.org/mozilla-central/rev/e690a2a67383
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Assignee

Comment 10

4 years ago
Updating bug to match what landed.
Attachment #8649017 - Attachment is obsolete: true
Attachment #8649958 - Flags: review+
Assignee

Comment 11

4 years ago
Comment on attachment 8649958 [details] [diff] [review]
measure-editor

Approval Request Comment
[Feature/regressing bug #]: Additional Telemetry in WebIDE to drive upcoming product decisions.  Most WebIDE users are on Dev. Ed., so this accelerates metrics collection.
[User impact if declined]: No real user impact, would just have to wait a cycle for useful metrics.
[Describe test coverage new/current, TreeHerder]: On m-c, updated test coverage.
[Risks and why]: Low, WebIDE only.
[String/UUID change made/needed]: None
Attachment #8649958 - Flags: approval-mozilla-aurora?

Comment 12

4 years ago
Jryan, just got back into town, realize this ticket is in "resolved mode" but here is some additional input. A useful metric would be how long user is on one project once he's opened it and also a time on the editing usage. We need to try to identify repeat usage in some way.
Flags: needinfo?(akratel)
Comment on attachment 8649958 [details] [diff] [review]
measure-editor

Should be low risk on the aurora release and should not impact the product. taking it.
Attachment #8649958 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

11 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.