1178964 - Measure editor usage in WebIDE

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Track whether the project editor is used in WebIDE.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Currently I am measuring:

* Displaying the project editing (existing project, new, etc.)
* Saving a file
* Creating a new project
* Importing an existing project

Happy to hear any feedback on additional metrics to measure.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: webide-telem

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Axel, we've talked about this in the past a bit.  Any additional editing metrics we should gather?

Alex, you may also have additional ideas.

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 8649017 [details] [diff] [review]
webide-telem

Review of attachment 8649017 [details] [diff] [review]:
-----------------------------------------------------------------

We could add many more probes, but I think that's enough for the project editor.
`webideProjectEditor` was really the most missing one!

::: browser/devtools/webide/content/webide.js
@@ +685,3 @@
>        } else {
>          this.projecteditor.menuEnabled = false;
> +        this._telemetry.toolClosed("webideProjectEditor");

I think we are going to call toolClosed multiple times if we switch between multiple non-project-editor decks.
Not a big deal if toolClosed handle this nicely.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=374ace828991

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Alexandre Poirot [:ochameau] from comment #4)
> ::: browser/devtools/webide/content/webide.js
> @@ +685,3 @@
> >        } else {
> >          this.projecteditor.menuEnabled = false;
> > +        this._telemetry.toolClosed("webideProjectEditor");
> 
> I think we are going to call toolClosed multiple times if we switch between
> multiple non-project-editor decks.
> Not a big deal if toolClosed handle this nicely.

Ah, I suppose you're right.  I'll remove my comment about only calling the function on a change.

Anyway, `toolClosed` does handle multiple calls in a row fine: it just stops a timer, if one was already running.

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Fixed test:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c5d49d3d7fc

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e690a2a67383

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e690a2a67383

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: measure-editor

Updating bug to match what landed.

Comment 11

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8649958 [details] [diff] [review]
measure-editor

Approval Request Comment
[Feature/regressing bug #]: Additional Telemetry in WebIDE to drive upcoming product decisions.  Most WebIDE users are on Dev. Ed., so this accelerates metrics collection.
[User impact if declined]: No real user impact, would just have to wait a cycle for useful metrics.
[Describe test coverage new/current, TreeHerder]: On m-c, updated test coverage.
[Risks and why]: Low, WebIDE only.
[String/UUID change made/needed]: None

Comment 12

[Axel Kratel]

Jryan, just got back into town, realize this ticket is in "resolved mode" but here is some additional input. A useful metric would be how long user is on one project once he's opened it and also a time on the editing usage. We need to try to identify repeat usage in some way.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8649958 [details] [diff] [review]
measure-editor

Should be low risk on the aurora release and should not impact the product. taking it.

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bf5fb167c2f5