1178976 - Post-write barriers missing in ObjectWeakMap

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

ObjectWeakMap::add fails to record the new JSObject key in the store buffer, so that a moving collection can rehash the entry when the JSObject is tenured.

Comment 1

[Jim Blandy :jimb]

Attachment: Add a post-write barrier to ObjectWeakMap::add.

Comment 2

[Terrence Cole [:terrence]]

You might want to recheck the weird weakmap bug you were seeing after applying this, given that it included weakmap entries going missing.

Comment 3

[Jim Blandy :jimb]

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=57c3732211d6

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/58a24ca605d9

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/58a24ca605d9

Comment 6

[Terrence Cole [:terrence]]

Clearning ni. Seems the issue was on an OHM.