Post-write barriers missing in ObjectWeakMap

RESOLVED FIXED in Firefox 42

Status

()

Core
JavaScript Engine
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jimb, Assigned: jimb)

Tracking

unspecified
mozilla42
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
ObjectWeakMap::add fails to record the new JSObject key in the store buffer, so that a moving collection can rehash the entry when the JSObject is tenured.
(Assignee)

Comment 1

3 years ago
Created attachment 8627898 [details] [diff] [review]
Add a post-write barrier to ObjectWeakMap::add.
Assignee: nobody → jimb
Status: NEW → ASSIGNED
Attachment #8627898 - Flags: review?(terrence)
Attachment #8627898 - Flags: review?(terrence) → review+
You might want to recheck the weird weakmap bug you were seeing after applying this, given that it included weakmap entries going missing.
Flags: needinfo?(sphink)
(Assignee)

Updated

3 years ago
Flags: in-testsuite-
Target Milestone: --- → mozilla42
https://hg.mozilla.org/mozilla-central/rev/58a24ca605d9
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Clearning ni. Seems the issue was on an OHM.
Flags: needinfo?(sphink)
You need to log in before you can comment on or make changes to this bug.