Closed
Bug 1178994
Opened 9 years ago
Closed 9 years ago
Pocket icon missing in Linux if Pocket is not in the toolbar
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 42
People
(Reporter: billm, Assigned: jaws)
References
Details
Attachments
(1 file)
59.48 KB,
patch
|
Gijs
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
STR: 1. Start a fresh Firefox profile on Linux. 2. Open "Customize" from hamburger menu. 3. Move the Pocket icon to "Additional Tools and Features" (i.e., the unused area). ER: The icon for Pocket disappears when it's in the Additional area. AR: There should be an icon for Pocket. Maybe we're missing some assets on Linux or something?
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Bill, are you running Linux in HiDPI mode (dppx > 1)? The Pocket icon exists in the 1dppx sprite but is missing from our 2dppx sprite, so that's the only way I can see this happening.
Flags: needinfo?(wmccloskey)
Attachment #8628064 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Comment 3•9 years ago
|
||
Thanks, the attached patch will fix the issue then.
Updated•9 years ago
|
Attachment #8628064 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 4•9 years ago
|
||
We will need to uplift this to aurora40, and beta39 once the HiDPI images get uplifted there too.
status-firefox40:
--- → affected
status-firefox41:
--- → affected
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8628064 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: bug 1169314 [User impact if declined]: pocket icons missing from menupanel and customize mode on linux in hidpi [Describe test coverage new/current, TreeHerder]: simple binary image update [Risks and why]: none [String/UUID change made/needed]: none
Attachment #8628064 -
Flags: approval-mozilla-aurora?
Comment 6•9 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4) > We will need to uplift this to aurora40, and beta39 once the HiDPI images > get uplifted there too. That's actually aurora41 / beta40 now. :)
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to Justin Dolske [:Dolske] from comment #6) > (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4) > > We will need to uplift this to aurora40, and beta39 once the HiDPI images > > get uplifted there too. > > That's actually aurora41 / beta40 now. :) Thanks for the correction. Yes, we will need to uplift this to aurora41, and eventually beta40 once the HiDPI images are uplifted to beta40.
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5a6cf346921f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8628064 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: bug 1169314 [User impact if declined]: pocket icons missing from menupanel and customize mode on linux in hidpi [Describe test coverage new/current, TreeHerder]: simple binary image update [Risks and why]: none [String/UUID change made/needed]: none
Attachment #8628064 -
Flags: approval-mozilla-beta?
Comment 11•9 years ago
|
||
Comment on attachment 8628064 [details] [diff] [review] Patch Non code update to fix Pocket use case on Linux. Beta+ Aurora+
Attachment #8628064 -
Flags: approval-mozilla-beta?
Attachment #8628064 -
Flags: approval-mozilla-beta+
Attachment #8628064 -
Flags: approval-mozilla-aurora?
Attachment #8628064 -
Flags: approval-mozilla-aurora+
Updated•9 years ago
|
status-firefox38.0.5:
--- → wontfix
status-firefox39:
--- → wontfix
Updated•9 years ago
|
Flags: qe-verify+
Updated•9 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•