Closed Bug 1178994 Opened 4 years ago Closed 4 years ago

Pocket icon missing in Linux if Pocket is not in the toolbar

Categories

(Firefox :: General, defect)

34 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 42
Tracking Status
firefox38.0.5 --- wontfix
firefox39 --- wontfix
firefox40 --- fixed
firefox41 --- fixed
firefox42 --- fixed

People

(Reporter: billm, Assigned: jaws)

References

Details

Attachments

(1 file)

STR:
1. Start a fresh Firefox profile on Linux.
2. Open "Customize" from hamburger menu.
3. Move the Pocket icon to "Additional Tools and Features" (i.e., the unused area).

ER:
The icon for Pocket disappears when it's in the Additional area.

AR:
There should be an icon for Pocket.

Maybe we're missing some assets on Linux or something?
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attached patch PatchSplinter Review
Bill, are you running Linux in HiDPI mode (dppx > 1)?

The Pocket icon exists in the 1dppx sprite but is missing from our 2dppx sprite, so that's the only way I can see this happening.
Flags: needinfo?(wmccloskey)
Attachment #8628064 - Flags: review?(gijskruitbosch+bugs)
Yes, I am running in HiDPI.
Flags: needinfo?(wmccloskey)
Thanks, the attached patch will fix the issue then.
Attachment #8628064 - Flags: review?(gijskruitbosch+bugs) → review+
We will need to uplift this to aurora40, and beta39 once the HiDPI images get uplifted there too.
Comment on attachment 8628064 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1169314
[User impact if declined]: pocket icons missing from menupanel and customize mode on linux in hidpi
[Describe test coverage new/current, TreeHerder]: simple binary image update
[Risks and why]: none
[String/UUID change made/needed]: none
Attachment #8628064 - Flags: approval-mozilla-aurora?
Depends on: 1169314
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4)
> We will need to uplift this to aurora40, and beta39 once the HiDPI images
> get uplifted there too.

That's actually aurora41 / beta40 now. :)
(In reply to Justin Dolske [:Dolske] from comment #6)
> (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4)
> > We will need to uplift this to aurora40, and beta39 once the HiDPI images
> > get uplifted there too.
> 
> That's actually aurora41 / beta40 now. :)

Thanks for the correction. Yes, we will need to uplift this to aurora41, and eventually beta40 once the HiDPI images are uplifted to beta40.
https://hg.mozilla.org/mozilla-central/rev/5a6cf346921f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment on attachment 8628064 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1169314
[User impact if declined]: pocket icons missing from menupanel and customize mode on linux in hidpi
[Describe test coverage new/current, TreeHerder]: simple binary image update
[Risks and why]: none
[String/UUID change made/needed]: none
Attachment #8628064 - Flags: approval-mozilla-beta?
Comment on attachment 8628064 [details] [diff] [review]
Patch

Non code update to fix Pocket use case on Linux. Beta+ Aurora+
Attachment #8628064 - Flags: approval-mozilla-beta?
Attachment #8628064 - Flags: approval-mozilla-beta+
Attachment #8628064 - Flags: approval-mozilla-aurora?
Attachment #8628064 - Flags: approval-mozilla-aurora+
Flags: qe-verify+
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.