1178998 - [e10s] Identify which hang detector detects a hang

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Jim Mathies [:jimm]]

Plugin and content process hangs get picked up by the e10s hang monitor and by the older dialog based plugin hang detector. AFAICT we don't differentiate in crash meta data, we should. This helps in diagnosing.

Comment 1

[Jim Mathies [:jimm]]

The newer hang monitor tags content processes with HangMonitor when we kill the child, but the plugin process doesn't receive any annotation.

http://mxr.mozilla.org/mozilla-central/source/dom/ipc/ProcessHangMonitor.cpp#842

Comment 2

[Jim Mathies [:jimm]]

Attachment: patch v.1

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/37ee808b82de

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/37ee808b82de

Comment 5

[Jim Mathies [:jimm]]

https://crash-stats.mozilla.com/report/index/e966a560-28f6-4b32-9f57-6efc82150709
https://crash-stats.mozilla.com/report/index/25b5ed26-683b-4900-bd84-577992150710

It seems most of our plugin hangs are still caught by the old modal ui. I don't see a lot of hang monitor reports. I'll extract some stats in one of my reports.

Comment 6

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #5)
> https://crash-stats.mozilla.com/report/index/e966a560-28f6-4b32-9f57-
> 6efc82150709
> https://crash-stats.mozilla.com/report/index/25b5ed26-683b-4900-bd84-
> 577992150710
> 
> It seems most of our plugin hangs are still caught by the old modal ui. I
> don't see a lot of hang monitor reports. I'll extract some stats in one of
> my reports.

Actually, most of these modal ui hangs are non-e10s, so this might be ok.