1179025 - Protect against using cursors on a deleted objectStore/index

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

From bug 1178829:

http://w3c-test.org/IndexedDB/idbcursor_advance_index9.htm
http://w3c-test.org/IndexedDB/idbcursor_advance_objectstore5.htm
http://w3c-test.org/IndexedDB/idbcursor_continue_index8.htm
http://w3c-test.org/IndexedDB/idbcursor_continue_objectstore6.htm

These are now fixed. The DOM changes were easy, but verifying stuff in the parent is a little more tricky. I think the old parameter verification for continue/advance was never called, so I moved some stuff around to make it more sane.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Sorry, previous version had a change from another bug mixed in.

Comment 2

[Jan Varga [:janv]]

Comment on attachment 8627990 [details] [diff] [review]
Patch, v1

Review of attachment 8627990 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c725221a7c45

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out for Werror bustage.
https://treeherder.mozilla.org/logviewer.html#?job_id=11313480&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/942d48fd522a

Comment 5

[Boris Zbarsky [:bzbarsky]]

Relanded with s/false/nullptr/ in the relevant function.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6063656f171

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Backed out for Werror bustage.
https://treeherder.mozilla.org/logviewer.html#?job_id=11397029&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/5041eb4fcb33

Comment 8

[Boris Zbarsky [:bzbarsky]]

Jan, is there a reason we have those two separate switch statements after this patch instead of a single combined one?

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch that builds on try

Not checking this in pending an answer to comment 8

Comment 10

[Jan Varga [:janv]]

(In reply to Boris Zbarsky [:bz] from comment #8)
> Jan, is there a reason we have those two separate switch statements after
> this patch instead of a single combined one?

Hm, thanks for catching this.
Yeah, it can be combined and objectStoreId and indexId can be removed too.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Well, objectStoreId and indexId _have_ to be removed to not turn the tree orange.

Can you do the combining, based on that last patch I attached?

Comment 12

[Jan Varga [:janv]]

Ok, I'll do it.

Comment 13

[Jan Varga [:janv]]

(In reply to Jan Varga [:janv] from comment #12)
> Ok, I'll do it.

Done.

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8c58fc312648

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8c58fc312648