1179056 - [Contacts] The loading bar flickers black on the top of the import sign in pages

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

The user will notice the loading line / bar is at the top of the Outlook and Gmail import sign in pages in Contacts. This line also flickers black. 

Repro Steps:
1) Update a Aries to 20150630220033
2) Open the "Contacts" app. 
3) Tap on the "Settings" icon. 
4) Tap on "Import Contacts".
5) Tap on "Gmail" or "Outlook" and pay close attention to the top of the screen.

Actual:
The loading bar appears on the top of the import sign in pages for Outlook and Gmail. This loading line also flickers black. 

Expected:
The loading bar does not appear at the top of the import sign in pages for Outlook and Gmail or no flickering black line occurs.

Environmental Variables:
Device: Aries 2.5
Build ID: 20150630220033
Gaia: 5997b406e77ea726fbd9047057a1c3504f6cd6d4
Gecko: 79800010be78
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Repro frequency: 5/5 100%
See attached: video, logcat

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue also occurs on the Flame 3.0

The loading bar appears at the top of the import sign in pages and it flickers black.

Device: Flame 2.5
BuildID: 20150630120106
Gaia: 5997b406e77ea726fbd9047057a1c3504f6cd6d4
Gecko: 291614a686f1
Gonk: a4f6f31d1fe213ac935ca8ede7d05e47324101a4
Version: 42.0a1 (2.5) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

I meant to say 2.5 in Comment 1.

This issue does not occur on Flame 2.2

The loading bar turns to black once the page has finished loading but it is not a flicker.

Device: Flame 2.2 (Full Flash)(KK)(319mb)
Build ID: 20150629162503
Gaia: b39d4f5b4937592ded19ec65e113a74177ae1f86
Gecko: cefa70ef71e4
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Maybe the bug is actually on 2.2? I am not sure what the intended behavior now that I look at the differences.

Comment 3

[Johan Lorenzo [:jlorenzo]]

I don't see the video or its URL. Would you mind putting it? Thanks!

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

I think the bug here is actually the way the loading bar is handled in 2.2 not 2.5. I am unsure of the expected behavior here. 

Here are the videos:

2.2 - Youtube is being slow in processing videos today so if this doesn't work check back later.

http://youtu.be/N71zQSsxh9c

2.5

https://youtu.be/rWn2k-P5BIw

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Borja I think we decided to skip this, can you give more info?

Comment 6

[Borja Salguero [:borjasalguero]]

This bar is part of the 'import' html, and it's not related with the work we are doing right now with NGA in Contacts. We kept this 'progress' bar in other parts of the UI (i.e. #new activity in Contacts) for compatibility with low-end devices.

Comment 7

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Visible regression.

Comment 8

[Johan Lorenzo [:jlorenzo]]

Comms triage: Systems Front End issue breaking the happy path and the first time experience in contact. Moving the issue to this team for the final call.

Comment 9

[Duane Dixon [:ddixon]]

According to the comments on this bug, it was never determined what a repro of this bug actually looks like (see comment 4).  So, for my regression window, my "Last Working" build shows that the loading bar DOES NOT flicker black.  My "First Broken" clearly showed that the loading bar DOES flicker black.  Further, I based my findings off of the Actual Results listed in comment 0.  

B2G Inbound Regression Window

Last Working 

Device: Flame 2.5
BuildID: 20150617090846
Gaia: 35c33cca1934211674f16d923f46be3ca7f4bd31
Gecko: a93d96a62f03
Version: 41.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

First Broken 

Device: Flame 2.5
BuildID: 20150617093246
Gaia: 50860c3e2dd9d85a371632f2102bf065f7eec206
Gecko: df7c5f43d4e8
Version: 41.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Last Working Gaia and First Broken Gecko
Issue DOES NOT occur here. 
Gaia: 35c33cca1934211674f16d923f46be3ca7f4bd31
Gecko: df7c5f43d4e8

Last Working Gecko and First Broken Gaia
Issue DOES occur here. 
Gaia: 50860c3e2dd9d85a371632f2102bf065f7eec206
Gecko: a93d96a62f03

B2G Inbound Pushlog (Gaia):
https://github.com/mozilla-b2g/gaia/compare/35c33cca1934211674f16d923f46be3ca7f4bd31...50860c3e2dd9d85a371632f2102bf065f7eec206

Possible Cause: 

Bug 1175160 - [Status Bar] Rocketbar is not updating it's color to match certain apps (Dialer/Messages/Contacts/Calendar)

Comment 10

[KTucker [:KTucker][Inactive 3/4/2016]]

Etienne, can you take a look at this please? I think this might have been caused when we reverted the patch for bug 1164123.

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] etiennesegonzac:bug-1179056 > mozilla-b2g:master

Comment 12

[Etienne Segonzac (:etienne)]

Comment on attachment 8658791 [details] [review]
[gaia] etiennesegonzac:bug-1179056 > mozilla-b2g:master

We're (rightfully so) only switching the |visibility| of the gaia progress.

But, since it was |position:relative| the rest of the appChrome was always pushed below, even once the progress was hidden.

This patch is switching it to |position:absolute| like it was intended to.

Comment 13

[Alberto Pastor [:albertopq]]

Comment on attachment 8658791 [details] [review]
[gaia] etiennesegonzac:bug-1179056 > mozilla-b2g:master

Given the comment in your PR, I have no option! :) Thanks!

Comment 14

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/pull/31766

Comment 15

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: The loading bar does not flicker black on the top of the import sign in pages.
See attachment: verified_Aries_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150910150202
Gaia Revision          6280500a6cb8d1b178cdd163450e36d22846fbed
Gaia Date              2015-09-10 11:38:24
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/7671701d15cadd2b343fc27685231e0689bb71df
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150910.182915
Firmware Date          Thu Sep 10 18:29:25 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20150911000328
Gaia Revision          6280500a6cb8d1b178cdd163450e36d22846fbed
Gaia Date              2015-09-10 11:38:24
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/c0abc2a6e11f52761366e029eb1bae4c9864a8a3
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150910.232411
Firmware Date          Thu Sep 10 23:24:19 UTC 2015
Bootloader             s1

Comment 16

[Shally Li（leave from Mozilla）]

Attachment: verified_Aries_v2.5.3gp