1179102 - The async version of loadSubscript doesn't get the right JS version.

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[[:fabrice] Fabrice Desré]

When calling Services.scriptloader.loadSubscriptWithOptions(uri, { async: true }) the JS version at http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/loader/mozJSSubScriptLoader.cpp#220 is 0, which means we can't have nice things.

Loading the same script synchronously we get the correct version, 180.

It seems like we're not using the right JS context here.

Bobby, any idea how to fix that?

Comment 1

[Bobby Holley (:bholley)]

You should do options.setVersion(JSVERSION_LATEST) in PrepareScript.

Comment 2

[[:fabrice] Fabrice Desré]

Attachment: asyncload-js-version.patch

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 8628545 [details] [diff] [review]
asyncload-js-version.patch

Review of attachment 8628545 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/loader/mozJSSubScriptLoader.cpp
@@ +129,5 @@
>                MutableHandleFunction function)
>  {
>      JS::CompileOptions options(cx);
>      options.setFileAndLine(uriStr, 1);
> +    options.setVersion(JSVERSION_LATEST);

All the setters on CompileOptions return a self-ref. So you can do:

options.setFileAndLine(uriStr, 1)
       .setVersion(JSVERSION_LATEST);

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/a2bfabc26c73

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a2bfabc26c73