1179116 - Some more cleanup for MediaDecoderStateMachine

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c51858ee277

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1179116_part1_MaybeStartPlayback_cleanup-v1.patch

MaybeStartPlayback() is now only called when state is DECODER_STATE_DECODING or DECODER_STATE_COMPLETED.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1179116_part2_FinishDecodeFirstFrame_cleanup-v1.patch

Remove unnecessary call to CheckIfDecodeComplete() since StartDecoding() also checks if decode is completed.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1179116_part3_misc-v1.patch

Remove unused code.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6eaed28d874
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a98d1ba3494
https://hg.mozilla.org/integration/mozilla-inbound/rev/b9f6249952e4

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d6eaed28d874
https://hg.mozilla.org/mozilla-central/rev/6a98d1ba3494
https://hg.mozilla.org/mozilla-central/rev/b9f6249952e4