Some more cleanup for MediaDecoderStateMachine

RESOLVED FIXED in Firefox 42

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(3 attachments)

Comment hidden (empty)
(Assignee)

Comment 2

4 years ago
Created attachment 8628165 [details] [diff] [review]
1179116_part1_MaybeStartPlayback_cleanup-v1.patch

MaybeStartPlayback() is now only called when state is DECODER_STATE_DECODING or DECODER_STATE_COMPLETED.
Assignee: nobody → jwwang
Status: NEW → ASSIGNED
Attachment #8628165 - Flags: review?(cpearce)
(Assignee)

Comment 3

4 years ago
Created attachment 8628167 [details] [diff] [review]
1179116_part2_FinishDecodeFirstFrame_cleanup-v1.patch

Remove unnecessary call to CheckIfDecodeComplete() since StartDecoding() also checks if decode is completed.
Attachment #8628167 - Flags: review?(cpearce)
(Assignee)

Comment 4

4 years ago
Created attachment 8628168 [details] [diff] [review]
1179116_part3_misc-v1.patch

Remove unused code.
Attachment #8628168 - Flags: review?(cpearce)
Attachment #8628165 - Flags: review?(cpearce) → review+
Attachment #8628167 - Flags: review?(cpearce) → review+
Attachment #8628168 - Flags: review?(cpearce) → review+
(Assignee)

Comment 5

4 years ago
Thanks for the review.
https://hg.mozilla.org/mozilla-central/rev/d6eaed28d874
https://hg.mozilla.org/mozilla-central/rev/6a98d1ba3494
https://hg.mozilla.org/mozilla-central/rev/b9f6249952e4
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.