117919 - PrinterEnumerator must work independently

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[rods (gone)]

The nsDocumentViewer now checks to see if there are any printers "installed"
before doing a Print or PrinterPreview.

It calls AvailablePrinters on the nsIPrintOptions. Currently, OS2 is not set for
this to be called outside of of the internals of printing. Or in otherwords, it
now only works from inside the nsDeviceContextSpecOS2.

You can look at the Windows impl and see a single I have written
"GlobalPrinters". This is set up to enumerate the printers on the system and can
be called from the DevSpec or from the PrinterEnumerator.

Also, when you fix this bug, please remove the OS2 ifdef from ns
DocumentViewer.cpp: 
http://lxr.mozilla.org/mozilla/source/content/base/src/nsDocumentViewer.cpp#4791

Comment 1

[Jessica Blanco]

Attachment: Took ifdef (XP_OS2) out of nsDocumentViewer.cpp

I attached a patch that takes out the defined(XP_OS2) in nsDocumentViewer.cpp.
I posted a fix for this in bug 113917. I will attach it here too.

Comment 2

[Jessica Blanco]

Attachment: Modified nsDeviceContextSpecOS2.cpp/h to use GlobalPrinters class like gtk

Comment 3

[rods (gone)]

r=rods

Comment 4

[Mike Kaply [:mkaply]]

Fix checked in

Comment 5

[sujay]

Michael, please verify and mark verified-fixed...thanks.

Comment 6

[sujay]

Mkaply, please verify....and mark verified-fixed...thanks.

Comment 7

[Mike Kaply [:mkaply]]

Sorry, missed this one.