PrinterEnumerator must work independently

VERIFIED FIXED

Status

()

Core
Printing: Output
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: rods (gone), Assigned: mkaply)

Tracking

Trunk
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
The nsDocumentViewer now checks to see if there are any printers "installed"
before doing a Print or PrinterPreview.

It calls AvailablePrinters on the nsIPrintOptions. Currently, OS2 is not set for
this to be called outside of of the internals of printing. Or in otherwords, it
now only works from inside the nsDeviceContextSpecOS2.

You can look at the Windows impl and see a single I have written
"GlobalPrinters". This is set up to enumerate the printers on the system and can
be called from the DevSpec or from the PrinterEnumerator.

Also, when you fix this bug, please remove the OS2 ifdef from ns
DocumentViewer.cpp: 
http://lxr.mozilla.org/mozilla/source/content/base/src/nsDocumentViewer.cpp#4791

Comment 1

17 years ago
Created attachment 63377 [details] [diff] [review]
Took ifdef (XP_OS2) out of nsDocumentViewer.cpp

I attached a patch that takes out the defined(XP_OS2) in nsDocumentViewer.cpp.
I posted a fix for this in bug 113917. I will attach it here too.

Comment 2

17 years ago
Created attachment 63379 [details] [diff] [review]
Modified nsDeviceContextSpecOS2.cpp/h to use GlobalPrinters class like gtk
(Reporter)

Comment 3

17 years ago
r=rods
(Assignee)

Comment 4

17 years ago
Fix checked in
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 5

17 years ago
Michael, please verify and mark verified-fixed...thanks.

Comment 6

17 years ago
Mkaply, please verify....and mark verified-fixed...thanks.
(Assignee)

Comment 7

17 years ago
Sorry, missed this one.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.