1179195 - [TABLET] Swipe to close a tab from tab panel animation is busted after performing specific scenario

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[u421692]

Attachment: device-2015-07-01-133634.png

Steps to reproduce:
1. Swipe to close multiple tabs really fast

Actual result:
Animation is performed without any issues

Expected result:
Animation stops and the tabs are positioned incorrectly. please see attached screenshot

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: ewww look at the screenshot

Comment 2

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Adding tracking flags for Firefox41 and Firefox42.

Comment 3

[Martyn Haigh (:mhaigh)]

Attachment: Swipe to close a tab from tab panel animation is busted after performing specific scenario

The issue was that if the user was swiping a lot of views away in rapid succession, at some point an animation would have not finished when the tabs got updated.  When this happened, the current X and Y positions of the tab were stored as part of the removal animation, unfortunately these positions were wrong as they referred to the mid-animation location of that view.  This fixes it by forcing the view back to the correct position before we record the location.

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 8628807 [details] [diff] [review]
Swipe to close a tab from tab panel animation is busted after performing specific scenario

Review of attachment 8628807 [details] [diff] [review]:
-----------------------------------------------------------------

Seems sane to me. If it builds and you can't repro, rock on.

Comment 5

[Martyn Haigh (:mhaigh)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9c7a747ca36

Comment 6

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/6e31fcd98f06

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6e31fcd98f06

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Martyn, is this fix safe to uplift to Aurora? It has been in nightly for a few weeks now.

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Mihai, could you please verify this issue is fixed for you in the latest Nightly build? If it is fixed, please update status resolved - fixed to resolved - verified. Thanks!

Comment 10

[u421692]

Verified as fixed on latest Nightly. Marking this Verified - fixed after the uplift on Aurora.

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Martyn, do you want to make a request to uplift this patch to Aurora? Given that the fix was verified, we should consider fixing it in FF41 as well. What do you think?

Comment 12

[Martyn Haigh (:mhaigh)]

Comment on attachment 8628807 [details] [diff] [review]
Swipe to close a tab from tab panel animation is busted after performing specific scenario

Approval Request Comment
[Feature/regressing bug #]: NA
[User impact if declined]: When users quicly swipe tabs closed, there's a good chance that the positions of the tabs will have not been reset and so will not appear in a grid layout.
[Describe test coverage new/current, TreeHerder]: Landed a while ago in Nightly with no fallout
[Risks and why]: Very low risk - could potentially slow down animation of tab layout in the tablet grid view.
[String/UUID change made/needed]: none

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8628807 [details] [diff] [review]
Swipe to close a tab from tab panel animation is busted after performing specific scenario

This code has been in m-c for a month, seems safe to uplift to Aurora. The fix has also been verified on Nightly42 which is great.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9f9255fa45c0