[TABLET] Swipe to close a tab from tab panel animation is busted after performing specific scenario

RESOLVED FIXED in Firefox 41

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: u421692, Assigned: mhaigh)

Tracking

(Blocks 1 bug, {regression})

41 Branch
Firefox 42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox39 unaffected, firefox40 unaffected, firefox41+ fixed, firefox42+ verified, fennec41+)

Details

Attachments

(2 attachments)

Steps to reproduce:
1. Swipe to close multiple tabs really fast

Actual result:
Animation is performed without any issues

Expected result:
Animation stops and the tabs are positioned incorrectly. please see attached screenshot
Summary: []TABLET] Swipe to close a tab from tab panel animation is busted after performing specific scenario → [TABLET] Swipe to close a tab from tab panel animation is busted after performing specific scenario
Assignee: nobody → mhaigh
[Tracking Requested - why for this release]: ewww look at the screenshot
tracking-fennec: --- → ?
Keywords: regression
Adding tracking flags for Firefox41 and Firefox42.
The issue was that if the user was swiping a lot of views away in rapid succession, at some point an animation would have not finished when the tabs got updated.  When this happened, the current X and Y positions of the tab were stored as part of the removal animation, unfortunately these positions were wrong as they referred to the mid-animation location of that view.  This fixes it by forcing the view back to the correct position before we record the location.
Attachment #8628807 - Flags: review?(rnewman)
Comment on attachment 8628807 [details] [diff] [review]
Swipe to close a tab from tab panel animation is busted after performing specific scenario

Review of attachment 8628807 [details] [diff] [review]:
-----------------------------------------------------------------

Seems sane to me. If it builds and you can't repro, rock on.
Attachment #8628807 - Flags: review?(rnewman) → review+
tracking-fennec: ? → 41+
https://hg.mozilla.org/mozilla-central/rev/6e31fcd98f06
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Martyn, is this fix safe to uplift to Aurora? It has been in nightly for a few weeks now.
Flags: needinfo?(mhaigh)
Mihai, could you please verify this issue is fixed for you in the latest Nightly build? If it is fixed, please update status resolved - fixed to resolved - verified. Thanks!
Flags: needinfo?(mihai.g.pop)
Verified as fixed on latest Nightly. Marking this Verified - fixed after the uplift on Aurora.
Flags: needinfo?(mihai.g.pop)
Martyn, do you want to make a request to uplift this patch to Aurora? Given that the fix was verified, we should consider fixing it in FF41 as well. What do you think?
Comment on attachment 8628807 [details] [diff] [review]
Swipe to close a tab from tab panel animation is busted after performing specific scenario

Approval Request Comment
[Feature/regressing bug #]: NA
[User impact if declined]: When users quicly swipe tabs closed, there's a good chance that the positions of the tabs will have not been reset and so will not appear in a grid layout.
[Describe test coverage new/current, TreeHerder]: Landed a while ago in Nightly with no fallout
[Risks and why]: Very low risk - could potentially slow down animation of tab layout in the tablet grid view.
[String/UUID change made/needed]: none
Flags: needinfo?(mhaigh)
Attachment #8628807 - Flags: approval-mozilla-aurora?
Comment on attachment 8628807 [details] [diff] [review]
Swipe to close a tab from tab panel animation is busted after performing specific scenario

This code has been in m-c for a month, seems safe to uplift to Aurora. The fix has also been verified on Nightly42 which is great.
Attachment #8628807 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.