117921 - Want attribute to hide outliner column headers

Status: RESOLVED WONTFIX

(Core :: XUL, enhancement, P3)

Description

[[e-mail]]

Rather than fiddling about with some obscure CSS (see e.g. autocomplete.css) it
would be much more useful if developers could use <outlinercols
collapsed="true"> or <outlinercols hidden="true"> to hide the column headers.
Unfortunately the former makes the entire outliner blank and the latter hangs
Mozilla unless you use the DOM inspector to apply it after it is created :-)

Comment 1

[Jeremy M. Dolan]

The new prefs needs this.

Additionally (maybe seperate bug material), the little column selector dohicky
should be disableable too (prefs DEFINATELY doesn't need it).

Comment 2

[Jan Varga [:janv]]

I just found how it works with XBL select.
- remove "label" attribute from outlinercol
- define style="border: none"
cool

Comment 3

[Jan Varga [:janv]]

taking for now

Comment 4

[Jan Varga [:janv]]

what about:

outlinercols[hidecols="true"] > outlinercol {
  margin: 0px !important;
  border: none !important;
  padding: 0px !important;
} 

Comment 5

[Håkan Waara]

Jan, that worksforme!

Comment 6

[Jan Varga [:janv]]

Actually, Joe already added a new attribute.

mozilla/themes/classic/win/tree.css
treecol[hideheader="true"] {                            
  -moz-appearance: none;
  border: none;
  padding: 0;
}

Joe, what about more general fix:

xul.css
tree[hidecols="true"] > treecols > treecol {
  -moz-appearance: none;
  border: none;
  padding: 0;
  margin: 0;
} 

attribute can be:
hidecols, hideheaders, borderlesscols, etc.

Comment 7

[Joe Hewitt (gone)]

Yeah, that's obviously a better way to do it.  Hyatt once told me that it would
be possible to do <treecols collapsed="true"/> but that collapses the entire
column, not just the header.  

Comment 8

[Jan Varga [:janv]]

Attachment: proposed fix

Comment 9

[Håkan Waara]

Wouldn't it just make much more sense to just do this if you wanted to hide the
treecolumns?

<treecols hidden="true">

Comment 10

[Jan Varga [:janv]]

1.
It seems that we add new attributes to root tag <tree>
hidecolumnpicker, seltype, onselect, etc.

2.
Generally, we use |hidden| attribute to hide elements completely, in other words
such element doesn't have any frame even.

The problem with treecol is that we want to visually hide it, but we still need
its frame to be present.
<treecol collapsed="true"/> is not helpfull too, since it has no width and we
need width to correctly paint columns in tree body.

Although, there is one exception, <treecol hidden="true"/> only collapses
<treecol> (frame is not destroyed)

Comment 11

[Håkan Waara]

The point is that since <treechildren/> is its own branch - not under the
<treecols/> tag, it makes sense (IMHO), to have the hidden attribute on that tag.

Comment 12

[[e-mail]]

Better more general fix for xul.css:
treecol[hideheader="true"] {
  -moz-binding: none;
}
But as -moz-binding: none; doesn't currently work I suggest
treecol[hideheader="true"] {
  -moz-binding: url("chrome://global/bindings/tree.xml#treecol-hide");
}
tree.xml
<binding id="treecol-hide"/>
<!--no stylesheet so no styles to undo!-->

Comment 13

[Jan Varga [:janv]]

Neil, do you really want hideheader for each treecol ?

Comment 14

[Jan Varga [:janv]]

Nominating for buffy.
I think, XUL developers really need this feature.

Comment 15

[[e-mail]]

Comment on attachment 77094 [details] [diff] [review]
proposed fix

>+tree[hideheaders="true"] > treecols > treecol {
>+  margin: 0px !important;
>+  border: none !important;
>+  padding: 0px !important;
>+}
>+

I still think a separate XBL binding (comment #12) would be more efficient plus
it would also more skinnable as putting styles in xul.css is ugly.

Comment 16

[Samir Gehani]

Nav triage team:  nsbeta1-

Comment 17

[Jan Varga [:janv]]

*** Bug 116118 has been marked as a duplicate of this bug. ***

Comment 18

[Jan Varga [:janv]]

I don't think anyone is going to work on this given the plan to remove XUL tree widget (bug 1446335).