Closed Bug 1179287 Opened 9 years ago Closed 6 years ago

-WError=strict-overflow causes -WError failures when gcc simply optimizes away a test

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: nical, Unassigned)

Details

See the comment in TestTiledLayerBuffer.cpp.

The error says "assuming signed overflow does not occur when assuming that (X+c) < X is always false"

Which is basically gcc warning that it optimized away an assertion and the warning gets caught in -WError.
The popular answer to this issue is to disable the warning with -Wno-strict-overflow.
(in the mean time I am just commenting out the assertions that caused it so that inbound can reopen)
Whiteboard: leave-open
Still hitting bustage. Skipping the test per nical's request.
https://hg.mozilla.org/integration/mozilla-inbound/rev/50e7a8b04313
Keywords: leave-open
Whiteboard: leave-open
Product: Core → Firefox Build System
The leave-open keyword is there and there is no activity for 6 months.
:kmoir, maybe it's time to close this bug?
Flags: needinfo?(kmoir)
:nical Can this bug be closed or should it be left open?
Flags: needinfo?(kmoir) → needinfo?(nical.bugzilla)
Flags: needinfo?(kmoir)
Let's close it.
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(nical.bugzilla)
Resolution: --- → INVALID
Flags: needinfo?(kmoir)
You need to log in before you can comment on or make changes to this bug.