Closed Bug 1179296 Opened 10 years ago Closed 4 years ago

Tapping the Add To Reading list buttons has no effect

Categories

(Firefox for Android Graveyard :: Reader View, defect)

41 Branch
x86
Android
defect
Not set
normal

Tracking

(firefox42 affected)

RESOLVED INCOMPLETE
Tracking Status
firefox42 --- affected

People

(Reporter: gcp, Unassigned)

Details

Motorola RaZRi, Android 4.1.2, current Aurora http://www.washingtonpost.com/news/volokh-conspiracy/ Open some of the articles and click the reading view icon. Tap the bottom of the screen and try to tap the "Add to Reading List" button. (Lower left). Expected: Article added to the reading list Actual: Nothing happens (IIRC the toolbar even disappears) This didn't reproduce 100% of the time.
OS: Unspecified → Android
Hardware: Unspecified → x86
Version: Trunk → Firefox 41
I can't reproduce this. Was there anything in the log when this happened?
Flags: needinfo?(gpascutto)
Still easily reproduces about 75% of the time. When it happens, there's nothing Gecko or FxA related in the log. When it does work, I get: 07-13 14:54:40.794 15650 15650 D GeckoToolbar: onTabChanged: MENU_UPDATED 07-13 14:54:40.794 15650 15650 D GeckoBrowserApp: BrowserApp.onTabChanged: 7: MENU_UPDATED or 07-13 14:52:23.154 15650 15829 D GeckoReadingListAcc: Updated 1 reading list rows. 07-13 14:52:23.164 15650 15650 D GeckoToolbar: onTabChanged: MENU_UPDATED 07-13 14:52:23.164 15650 15650 D GeckoBrowserApp: BrowserApp.onTabChanged: 7: MENU_UPDATED 07-13 14:52:23.164 17349 17424 I GCoreUlr: Successfully inserted location 07-13 14:52:23.174 17349 17424 I GCoreUlr: Not calling LocationReporter, hasMoved: false, elapsed millis: 180467, request: Stationary(3600000) 07-13 14:52:23.494 15650 15829 D GeckoReadingListAcc: Updated 1 reading list rows. 07-13 14:52:23.494 15650 15650 D GeckoToolbar: onTabChanged: MENU_UPDATED 07-13 14:52:23.494 15650 15650 D GeckoBrowserApp: BrowserApp.onTabChanged: 7: MENU_UPDATED 07-13 14:52:23.614 15650 15829 D GeckoReadingListAcc: Updated 1 reading list rows. 07-13 14:52:23.624 15650 15650 D GeckoToolbar: onTabChanged: MENU_UPDATED 07-13 14:52:23.624 15650 15650 D GeckoBrowserApp: BrowserApp.onTabChanged: 7: MENU_UPDATED 07
Flags: needinfo?(gpascutto)
I reproduced this on a RAZRi (Android 4.1.2) and a Nexus 4 (Android 5.1) Both times, I saw the following: 1. Load a page into Reader View 2. Tap to make the toolbar appear 3. Tap "Add to Reading List" button 4. Nothing happens Tapping on any toolbar button does nothing! However, I also saw this: 1. Load a page into Reader View 2. Pan the page down a little, then pan back up to top 3. Tap to make the toolbar appear 4. Tap "Add to Reading List" button 5. Page is added to the reading list Tapping on any toolbar button works! It looks like the the click handlers are not hooked up until we pan?
I wonder if this is a regression from the eslint stuff. I looked through the relevant bugs and nothing jumped out at me, but maybe Margaret has the necessary context? bug 1170804 and bug 1177774 should be the ones where I made changes.
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.