1179337 - Logviewer console errors on first-click of a failure-step button edge

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Jonathan French (:jfrench)]

The Logviewer console errors when first clicking on a failure-step button edge.

To reproduce:
o open any failed job in Logviewer eg.
https://treeherder.mozilla.org/logviewer.html#?job_id=11257981&repo=mozilla-inbound
o open the console
o click on the pale orange perimeter of the failure step

Expected:
A clean load of the failure step.

Observed:
(console) Uncaught TypeError: Cannot read property 'top' of undefined

Which exists here:
https://github.com/mozilla/treeherder/blob/master/ui/js/directives/log_viewer_steps.js#L12

It errors the same on any step type (failure, or success). Subsequent clicks seem to be fine.

It doesn't appear to be related to the recent work in bug 1057341 for the new logviewer step color treatment and header work (I rolled back to one commit prior and still reproduced it).

Comment 1

[Jonathan French (:jfrench)]

Attachment: stepClickError

Per screen grab.

Comment 2

[Jonathan French (:jfrench)]

Attachment: PR 876

PR for leisurely review :)

Comment 3

[Cameron Dawson [:camd]]

Comment on attachment 8648749 [details] [review]
PR 876

lgtm.  :)

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/7c15aeb4ced90369029af287d1cf8a4eb60969bd
Bug 1179337 - Quiet logviewer error on first-click of a failure-step

Comment 5

[Jonathan French (:jfrench)]

Marking fixed per above merge. Will verify on the next stage/prod push.

Comment 6

[Jonathan French (:jfrench)]

Verified fixed on production. We now automatically select the first failure, so verification was done with manual workflows after load.