Closed Bug 1179343 Opened 5 years ago Closed 5 years ago

Security "WPA2 (AES)" is enabled but read only

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: scabral, Assigned: scottwu, Mentored)

Details

(Keywords: foxfood, Whiteboard: [good first bug][mentor-lang=zh][lang=js])

Attachments

(3 files, 1 obsolete file)

Security "WPA2 (AES)" is enabled but read only
In the hotspot settings pane.
Component: General → Gaia::Settings
QA Whiteboard: [foxfood-triage]
Flags: needinfo?(firefoxos-ux-bugzilla)
I think you're refering to the read-only info fields in the "Internet sharing" settings menu. To change Hotspot settings you must use the submenu of the same name.
Does comment 2 mean this isn't a bug?
NI - see comment 3
Flags: needinfo?(scabral)
Flags: needinfo?(rsoderberg)
Flags: needinfo?(firefoxos-ux-bugzilla)
Flags: needinfo?(scabral)
(In reply to Christiane Ruetten [:cr] from comment #2)
> I think you're refering to the read-only info fields in the "Internet
> sharing" settings menu. To change Hotspot settings you must use the submenu
> of the same name.

Oh, I see. So we have two copies of this setting - one that can be altered, and one that cannot.

That seems unintuitive to me. Shouldn't I be able to alter these settings where they're displayed? They're shown as settings, and look like settings, and do nothing when tapped.

Perhaps tapping them should open the settings pane where they can be altered, rather than doing nothing?
Flags: needinfo?(rsoderberg)
Adding NI for triage today
Flags: needinfo?(firefoxos-ux-bugzilla)
UX triage results:

* the name and security label items are a nice convenience, but not absolutely required, as the information is redundant.

* an ok solution would be to remove both labels

* an ok solution would be restyle both labels such that they're clearly read-only informational labels, not interactive

* a better solution would be to remove both labels, but append the information to the bottom of the label above them, that beings "allow other devices..."

Screenshot and mockup coming.
Flags: needinfo?(firefoxos-ux-bugzilla)
Set it as good first bug if @harly has no special concern for this.

The tasks are:

1. remove `Name` & `Security` list item
2. append name as description in `Wi-Fi Hotspot` switch, ex:

Wi-fi Hotspot  <switch>
hotspot name
Flags: needinfo?(hhsu)
Whiteboard: good-first-bug, zh
Thank you Sheeri for pointing this out, this is an inconsistency issue that I wanted to fix for a long time. And I agree with Fred's idea to have the hotspot name as description when user has enabled Wifi hotspot. But I was thinking the string below would make more sense.

Wi-fi Hotspot            <switch>
Hotspot "hotspot name" is enabled
Flags: needinfo?(hhsu)
Whiteboard: good-first-bug, zh → [good first bug][mentor-lang=zh]
Mentor: gasolin
Whiteboard: [good first bug][mentor-lang=zh] → [good first bug][mentor-lang=zh][lang=js]
Attachment #8656393 - Attachment is obsolete: true
Attachment #8657764 - Flags: review?(gasolin)
Assignee: nobody → scwwu
Comment on attachment 8657764 [details] [review]
[gaia] scottwu:1179343-hotspot-enable-disable-msg > mozilla-b2g:master

Thanks for provide the patch, please address comments in github then set review again.
Attachment #8657764 - Flags: review?(gasolin)
Comment on attachment 8657764 [details] [review]
[gaia] scottwu:1179343-hotspot-enable-disable-msg > mozilla-b2g:master

Thanks for the review!

I've addressed your concerns. Please take a look again.
Attachment #8657764 - Flags: review?(gasolin)
Comment on attachment 8657764 [details] [review]
[gaia] scottwu:1179343-hotspot-enable-disable-msg > mozilla-b2g:master

Checked UI with Harly and test fine on device

merged https://github.com/mozilla-b2g/gaia/commit/7e9315183b91fe549a75750d784b1fecafe426c2

thanks!
Attachment #8657764 - Flags: review?(gasolin) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.