1179343 - Security "WPA2 (AES)" is enabled but read only

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Sheeri Cabral [:sheeri]]

Security "WPA2 (AES)" is enabled but read only

Comment 1

[:Atoll]

In the hotspot settings pane.

Comment 2

[Christiane Ruetten [INACTIVE]]

I think you're refering to the read-only info fields in the "Internet sharing" settings menu. To change Hotspot settings you must use the submenu of the same name.

Comment 3

[Tiffanie Shakespeare [:tif]]

Does comment 2 mean this isn't a bug?

Comment 4

[Tiffanie Shakespeare [:tif]]

NI - see comment 3

Comment 5

[:Atoll]

(In reply to Christiane Ruetten [:cr] from comment #2)
> I think you're refering to the read-only info fields in the "Internet
> sharing" settings menu. To change Hotspot settings you must use the submenu
> of the same name.

Oh, I see. So we have two copies of this setting - one that can be altered, and one that cannot.

That seems unintuitive to me. Shouldn't I be able to alter these settings where they're displayed? They're shown as settings, and look like settings, and do nothing when tapped.

Perhaps tapping them should open the settings pane where they can be altered, rather than doing nothing?

Comment 6

[Tiffanie Shakespeare [:tif]]

Adding NI for triage today

Comment 7

[Dietrich Ayala (:dietrich)]

UX triage results:

* the name and security label items are a nice convenience, but not absolutely required, as the information is redundant.

* an ok solution would be to remove both labels

* an ok solution would be restyle both labels such that they're clearly read-only informational labels, not interactive

* a better solution would be to remove both labels, but append the information to the bottom of the label above them, that beings "allow other devices..."

Screenshot and mockup coming.

Comment 8

[Dietrich Ayala (:dietrich)]

Attachment: Screenshot of problematic screen

Comment 9

[Dietrich Ayala (:dietrich)]

Attachment: High resolution pixel-perfect mockup

Comment 10

[[e-mail]]

Set it as good first bug if @harly has no special concern for this.

The tasks are:

1. remove `Name` & `Security` list item
2. append name as description in `Wi-Fi Hotspot` switch, ex:

Wi-fi Hotspot  <switch>
hotspot name

Comment 11

[Harly Hsu[:harly]]

Thank you Sheeri for pointing this out, this is an inconsistency issue that I wanted to fix for a long time. And I agree with Fred's idea to have the hotspot name as description when user has enabled Wifi hotspot. But I was thinking the string below would make more sense.

Wi-fi Hotspot            <switch>
Hotspot "hotspot name" is enabled

Comment 12

[GitHub Autolander Bot]

Attachment: [gaia] scottwu:1179344-hotspot-security-name > mozilla-b2g:master

Comment 13

[GitHub Autolander Bot]

Attachment: [gaia] scottwu:1179343-hotspot-enable-disable-msg > mozilla-b2g:master

Comment 14

[[e-mail]]

Comment on attachment 8657764 [details] [review]
[gaia] scottwu:1179343-hotspot-enable-disable-msg > mozilla-b2g:master

Thanks for provide the patch, please address comments in github then set review again.

Comment 15

[Scott Wu [:scottwu]]

Comment on attachment 8657764 [details] [review]
[gaia] scottwu:1179343-hotspot-enable-disable-msg > mozilla-b2g:master

Thanks for the review!

I've addressed your concerns. Please take a look again.

Comment 16

[[e-mail]]

Comment on attachment 8657764 [details] [review]
[gaia] scottwu:1179343-hotspot-enable-disable-msg > mozilla-b2g:master

Checked UI with Harly and test fine on device

merged https://github.com/mozilla-b2g/gaia/commit/7e9315183b91fe549a75750d784b1fecafe426c2

thanks!