1179410 - Screen Lock: Enabled should say "without passcode"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Sheeri Cabral [:sheeri]]

Screen Lock: Enabled should say "without passcode"

Comment 1

[:Atoll]

In the Settings pane, where it says:

Screen Lock  >
Enabled

It should say

Screen Lock  >
Enabled without passcode

Because it's not really locked if there's not a PIN set.

Comment 2

[[e-mail]]

@harly if you think its fine we can add it into backlog.


There will be 2 cases in root panel:

1. Lock Screen enabled & Passcode Lock disabled

Screen Lock  >
Enabled

2. Lock Screen enabled & Passcode Lock enabled

Screen Lock  >
Enabled without passcode

Comment 3

[:Atoll]

Are those two conditions reversed? I would expect more like:

1. Lock disabled

Enabled without passcode

2. Lock enabled

Enabled (or, Enabled with passcode)

Comment 4

[[e-mail]]

yeah, sorry for the miss typing.

Comment 5

[Harly Hsu[:harly]]

Let me clarify, so there seems to be 3 states:

1. Lock Screen enabled & Passcode Lock disabled

Screen Lock  >
Enabled with no passcode

2. Lock Screen enabled & Passcode Lock enabled

Screen Lock  >
Enabled with passcode

3. Lock Screen disabled

Screen Lock  >
Disabled

Also, should we unify the wording of Screen Lock and Lock Screen to just Lock Screen? It is a little confusing.

Comment 6

[[e-mail]]

[Tracking Requested - why for this release]: nice to have ux improvement

Comment 7

[[e-mail]]

@matej please help check the wording is correct in Comment 5, thanks!

Comment 8

[Matej Novak [:matej]]

(In reply to Harly Hsu[:harly] from comment #5)
> Let me clarify, so there seems to be 3 states:
> 
> 1. Lock Screen enabled & Passcode Lock disabled
> 
> Screen Lock  >
> Enabled with no passcode
> 
> 2. Lock Screen enabled & Passcode Lock enabled
> 
> Screen Lock  >
> Enabled with passcode
> 
> 3. Lock Screen disabled
> 
> Screen Lock  >
> Disabled

These look good to me.

> Also, should we unify the wording of Screen Lock and Lock Screen to just
> Lock Screen? It is a little confusing.

It actually depends where and how they're used. "Screen Lock" is the name of the feature, but "Lock Screen" could be a prompt to actually enable it, so we may need to keep both.

In the above examples, for instance, it should remain "Screen Lock."

Comment 9

[Ricky Chien [:rickychien] (inactive)]

Take it.

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] rickychien:issue-1179410 > mozilla-b2g:master

Comment 11

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8655323 [details] [review]
[gaia] rickychien:issue-1179410 > mozilla-b2g:master

Hey gasolin, could you help me review that small patch kindly? thanks!

Comment 12

[Ricky Chien [:rickychien] (inactive)]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/12e4a642fa949ca17646ce4db56394b131c49fb8