1179415 - Entering an invalid passcode match presents a warning but does not clear the codes

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Sheeri Cabral [:sheeri]]

Entering an invalid passcode match presents a warning but does not clear the codes

Comment 1

[:Atoll]

See also bug 1179416 for a related but different issue.

Comment 2

[[e-mail]]

Currently the warning presents without clean the codes, type anything will then clean the codes.


@harly If you think the suggestion change (clear the codes when warning presents) is fine, I'll add it into backlog.

Comment 3

[Harly Hsu[:harly]]

Yes, please clear the code when passcode don't match, thanks :)

Comment 4

[[e-mail]]

[Tracking Requested - why for this release]: nice to have UX improvement

good first bug if you have fxos device

Comment 5

[jgw9617]

(In reply to Fred Lin [:gasolin] from comment #4)
> [Tracking Requested - why for this release]: nice to have UX improvement
> 
> good first bug if you have fxos device

I have an LG Fx0 that I shallow-flashed 2.6 onto, so id like to take this bug please! I was able to repro the bug.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] jgw96:invalid-passcode > mozilla-b2g:master

Comment 7

[jgw9617]

Pull request submitted above!

Comment 8

[[e-mail]]

Of course! Thanks for help.

Please set review(by click `Details` and choose `?` with my email) once you feel the patch is ready

Comment 9

[jgw9617]

Will do, its almost ready. What's the thought on a short vibration when the passcode is entered wrong along with clearing it obviously? Currently I have it clearing but I feel like it could use a short vibration to enforce that the user got it wrong. Also is this just for when your editing the passcode? Or when your confirming your passcode and get it wrong? Or both?

Comment 10

[jgw9617]

This would be emulating the behavior on the lockscreen when you have a passcode set and type it in wrong.

Comment 11

[[e-mail]]

Tina could you help make some UX decision when user have type wrong password?


My thought: If you find there's an existing behavior that similar to this situation, it likely can be applied. Though we need consistency in settings, so if you want that happen, I suggest you do it in a separate bug. To Findout passcode input in several places in settings and wrap them as a web component, so we could change the behavior at once.

Comment 12

[jgw9617]

Comment on attachment 8697889 [details] [review]
[gaia] jgw96:invalid-passcode > mozilla-b2g:master

Added a commit to fix what was discussed

Comment 13

[[e-mail]]

Comment on attachment 8697889 [details] [review]
[gaia] jgw96:invalid-passcode > mozilla-b2g:master

Thanks for the update. Please address the unit test fail and send review again. (I guess its because the miss type of `_` for `_updatePassCodeUI` method)

And please follow the article to squash your commits into 1 commit 
http://eragonj.me/blog/fxos-why-we-need-to-squash-commits.html

Comment 14

[[e-mail]]

Comment on attachment 8697889 [details] [review]
[gaia] jgw96:invalid-passcode > mozilla-b2g:master

The patch works, though I found it just fix partial of the issue.


Reproducable steps:

In Screen lock panel

1. toggle the Screen Lock > Passcode Lock switch on or off
2. 'New passcode' panel is shown
3. type miss matched numbers, the error message is shown, but the input fields are not cleared

Can you help deal with these cases? Thanks :)

Comment 15

[[e-mail]]

If you need any help to further enhance the patch, please let me know :)

Comment 16

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:invalid-passcode > mozilla-b2g:master

Comment 17

[[e-mail]]

jgw96 I've rebased your patch and adding the missed case. Will merge it when all tests pass. Thanks for help!

Comment 18

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/936300ee4ebdc1ec2623f73f4e675159aea0811d

thanks!