Closed
Bug 1179464
Opened 9 years ago
Closed 8 years ago
"start communicating" is odd phrasing
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(tracking-b2g:backlog, b2g-v2.5 affected, b2g-master verified)
RESOLVED
FIXED
tracking-b2g | backlog |
People
(Reporter: wenzel, Assigned: Alexey.Yakimov)
References
Details
(Keywords: foxfood, Whiteboard: 2.6UXnom)
Attachments
(5 files)
Feel free to wontfix this but anyway: The Messaging app's "Start communicating" call to action trips me up because it is almost actionable, but not quite, therefore it might be a bad CTA. "communicating" is an abstract concept ("expressing ideas"), not a concrete action. "Start by writing a message" or something similar would be a concrete thing I can achieve with this app, and seems to be a better CTA.
Comment 1•9 years ago
|
||
[Tracking Requested - why for this release]: UX flag for alternative phrasing.
Comment 2•9 years ago
|
||
NI'ing Matej for help with string and Harly and FYI. Thanks for pinging the UX team!
Flags: needinfo?(matej)
Flags: needinfo?(hhsu)
Flags: needinfo?(firefoxos-ux-bugzilla)
Comment 3•9 years ago
|
||
Can someone share a screenshot of where and how this appears in context? Thanks.
Flags: needinfo?(matej)
Reporter | ||
Updated•9 years ago
|
Severity: normal → trivial
Comment 5•9 years ago
|
||
Thanks. It does seem a little odd, though not just in the wording. The icon to create a message is far removed from the copy. Do we need anything there at all? It could be something like "Start a conversation" or "Send one now," but I'm not sure we need it.
Flags: needinfo?(matej)
Comment 6•9 years ago
|
||
Ni Morpheus to keep an eye on this.
Flags: needinfo?(hhsu) → needinfo?(mochen)
Comment 7•9 years ago
|
||
Thanks for addressing the issue. I think it's odd too, but I found this is not only happened in Message, you can find the same message when there is no call log. So I will sync up with the UX owner of phone to make it consistent and update the spec. Second, as Matej mentioned "The icon to create a message is far removed from the copy." You can find some examples which not only show welcome message but also display a button at the same time. Like this: https://drive.google.com/file/d/0B_NalwdgcXpqenN5QzRYeUNTOFU/view?usp=sharing UX team will have an internal sync up to make sure every app align with this feature. Let me know if any questions, thanks.
Flags: needinfo?(mochen)
Comment 8•9 years ago
|
||
Please find the attachment for the updated welcome message. The string will be consistent with Phone app.
Updated•9 years ago
|
Whiteboard: 2.6UXnom
Comment 9•9 years ago
|
||
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8691360 [details] [review] [gaia] AlekoNN:bug_1179464 > mozilla-b2g:master Fabrice, please review the changes or assign someone else to check it. Thanks in advance.
Attachment #8691360 -
Flags: review?(fabrice)
Comment 11•9 years ago
|
||
Comment on attachment 8691360 [details] [review] [gaia] AlekoNN:bug_1179464 > mozilla-b2g:master In general you need to change the l10n property when changing the content. In this case I'm not sure if we are just fixing the en-US copy or if that will also impact localizers. Stas, I'll defer to you!
Attachment #8691360 -
Flags: review?(fabrice) → review?(stas)
Comment 12•9 years ago
|
||
Comment on attachment 8691360 [details] [review] [gaia] AlekoNN:bug_1179464 > mozilla-b2g:master Thanks, Fabrice, and yes, you're right. We'll need to change the id of the translation to make sure localizers know that the meaning of this message has changed. Possilble new ids: - noMessages2-text - noMessages-text2 - startConversation-text You'll also need to change the id in the HTML files using this string: apps/sms/views/inbox/index.html apps/sms/index.html Thanks!
Attachment #8691360 -
Flags: review?(stas) → review-
Assignee | ||
Comment 13•9 years ago
|
||
Fabrice, Stas, thanks for your comments. I also noticed that there is Chinese version of such string avilable here (in test folder): gaia/build/test/resources/locales/zh-CN/apps/sms/sms.properties Please advise whether I should keep this file as it is now or should I request someone to provide a traslation?
Flags: needinfo?(stas)
Assignee | ||
Comment 14•8 years ago
|
||
Comment on attachment 8691360 [details] [review] [gaia] AlekoNN:bug_1179464 > mozilla-b2g:master Stas, please review new version with modified localization ID.
Attachment #8691360 -
Flags: review- → review?(stas)
Assignee | ||
Comment 15•8 years ago
|
||
As per comment#10 in bug 1190683, the files in test folder are just a fixture used for build tests, so no need to change them. New commit with updated l10n ID is uploaded.
Flags: needinfo?(stas)
Comment 16•8 years ago
|
||
Comment on attachment 8691360 [details] [review] [gaia] AlekoNN:bug_1179464 > mozilla-b2g:master Ah, thanks for researching the solution! lgtm, r=me.
Attachment #8691360 -
Flags: review?(stas) → review+
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → Alexey.Yakimov
Keywords: checkin-needed
Comment 17•8 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/8e69eb6171c2a948fe56b31d97146e45c699746c
Status: NEW → RESOLVED
Closed: 8 years ago
status-b2g-master:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Comment 18•8 years ago
|
||
Why are we keeping noMessages-text around? Is still used somewhere? You should remove strings when they are no longer used.
Flags: needinfo?(Alexey.Yakimov)
Assignee | ||
Comment 19•8 years ago
|
||
No, it is not used any longer, so it is safe to remove it. Sorry, I was not aware about this rules. Should I update the l10n file and commit a new version in spite the PR has already been merged?
Flags: needinfo?(Alexey.Yakimov)
Comment 20•8 years ago
|
||
(In reply to Alexey Yakimov from comment #19) > Should I update the l10n file and commit a new version in spite the PR has > already been merged? That's up to you. You can land a follow-up in this bug, or file a new one just for the removal. I take removing it here would be faster.
Comment 21•8 years ago
|
||
Assignee | ||
Comment 22•8 years ago
|
||
Comment on attachment 8694666 [details] [review] [gaia] AlekoNN:bug_1179464_1 > mozilla-b2g:master Francesco, please review. noMessages-text was removed.
Attachment #8694666 -
Flags: review?(francesco.lodolo)
Comment 23•8 years ago
|
||
Comment on attachment 8694666 [details] [review] [gaia] AlekoNN:bug_1179464_1 > mozilla-b2g:master It looks good to me, but you'll probably need a proper reviewer for autoland to work
Attachment #8694666 -
Flags: review?(francesco.lodolo) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 24•8 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/88a93d53fcddb91e5ceef54fbfc2c839a3299b4b
Keywords: checkin-needed
Comment 25•8 years ago
|
||
This bug has been verified as "pass" on the latest build of Flame master and Aries KK master by the STR in comment 0. Actual results: It shows "Start a conversation now" in Messages. See attachment: verified_Flame_master_message.png Reproduce rate: 0/10 Device: Flame master_512mb (Pass) Build ID 20151206150208 Gaia Revision b930e25e9f2e5ec2106dd31005468575cdf87d50 Gaia Date 2015-12-05 03:41:55 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/cc9c6cd756cb744596ba039dcc5ad3065a7cc3ea Gecko Version 45.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20151206.184313 Firmware Date Sun Dec 6 18:43:25 EST 2015 Firmware Version v18D v4 Bootloader L1TC000118D0 Device: Aries KK master (Pass) Build ID 20151206002630 Gaia Revision b930e25e9f2e5ec2106dd31005468575cdf87d50 Gaia Date 2015-12-05 03:41:55 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/cc9c6cd756cb744596ba039dcc5ad3065a7cc3ea Gecko Version 45.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20151205.234548 Firmware Date Sat Dec 5 23:45:56 UTC 2015 Bootloader s1
QA Whiteboard: [foxfood-triage] → [foxfood-triage][MGSEI-Triage+]
status-b2g-v2.5:
--- → affected
Comment 26•8 years ago
|
||
Comment 27•8 years ago
|
||
I see that everything here landed without a review from the SMS peers :( Moreover do we have a bug for Call log too, as morpheus suggested in comment 7?
Comment 28•8 years ago
|
||
(In reply to Julien Wajsberg [:julienw] (PTO -> 2016) from comment #27) > Moreover do we have a bug for Call log too, as morpheus suggested in comment > 7? I assume that would be bug 1190683
You need to log in
before you can comment on or make changes to this bug.
Description
•